Re: [PATCH] Try to adapt to recent compilers such as GCC 14

Ingo Brückl <[email protected]> Tue, 01 Oct 2024 15:37:52 +0200

Newsgroups	gmane.comp.video.mplayer.devel
Message-ID	<[email protected]>

Lorenzo wrote on Tue, 1 Oct 2024 14:25:54 +0200:

> On Tue, 01 Oct 2024 14:13:36 +0200
> Ingo Br=FCckl <[email protected]> wrote:

>> Lorenzo wrote on Tue, 1 Oct 2024 12:52:48 +0200:
>>
>> > with this patch applied it still fails[1] to build on i386 (Debian)
>> > for me, with
>>
>> >    73 |     if (iconv(inv_msgiconv, (const char **)&filename, &filenam=
e_len,
>> >       |                             ^~~~~~~~~~~~~~~~~~~~~~~~
>> >       |                             |
>> >       |                             const char **
>>
>> Which patch? It's okay in current svn.

> Apologies, I was not subscribed so I just copied the subject without a
> proper quote; the patch posted in
> https://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2024-September/07421=
7.html

This patch is broken regarding all (const char **) casts for iconv()
which takes char ** as a second argument.

Ingo