Re: [PATCH] mplayer has broken Letterboxing with xv Video Output on i3wm

Hi Reimar, thanks for having a look!

On Sat, May 21, 2022 at 10:38:42PM +0200, Reimar D=F6ffinger wrote:
>FYI one important case that needs testing is that resizing works, =

>smoothly and flicker-free.

I tested this right now both with and without a compositor (picom). I =

can't see any flicker on the video in all cases.

>That has been the reason why in the past it was not fixed, breaking =

>tiling window managers seemed preferable of breaking resizing with =

>non-tiling window managers.
>I think the issue is that with PAspect you would still end up with =

>window sizes a few pixels off.

Right, I can see that (with some debug printfs): during resizing, the =

window size is sometimes (not always) one pixel larger than the video =

size in one of the dimensions. IMO if that happens, filling the blank =

space is still the correct thing to do.

>So you would end up drawing these borders even though the tiny bad =

>lines are of no real consequence (and probably should be fixed by =

>changing the size of the video that is drawn).
>And doing so, especially during a resize sequence results in really bad =

>flickering.

Are you talking about the video or the border flickering? The only kind =

of 'flicker' I can observe is that the video resizing lags behind/isn't =

synched to the window resizing (giving either a little bit of black on =

the right and bottom edge when increasing window size, or clipping the =

video in the same corner when making the window smaller). That happens =

with and without my patch and is (i believe) unrelated to drawing the =

letter/pillarboxes. If it were, I'd expect to see 1px wide lines, not =

whole sections.


	tobi