default faac object type

Gleb Smirnoff <[email protected]> Sun, 11 Jul 2021 17:12:40 -0700
Newsgroups gmane.comp.video.mplayer.devel
Message-ID <[email protected]>
--HV57r+2lsJirjBrV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

since 2017 libfaac no longer supports any object type
other than LOW:

#diff-41dda09fa8245ed46fc2dffa26a2f397d293adc5269b6c7dcd8dc53ba6a5e3e5

This basically makes it mandatory to specify '-faacopts object=2'
for any invocation of '-oac faac'.

Suggested minimal patch defaults the value to LOW. However, maybe
makes sense to remove object subagument at all?

-- 
Gleb Smirnoff

--HV57r+2lsJirjBrV
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="faac_object_type.diff"

Index: libmpcodecs/ae_faac.c
===================================================================
--- libmpcodecs/ae_faac.c	(revision 38313)
+++ libmpcodecs/ae_faac.c	(working copy)
@@ -31,6 +31,7 @@
 #include "stream/stream.h"
 #include "libmpdemux/muxer.h"
 #include <faac.h>
+#include <faaccfg.h>
 #include "ae.h"
 #include "ae_faac.h"
 
@@ -40,7 +41,7 @@ static faacEncConfigurationPtr config = NULL;
 static int
 	param_bitrate = 128,
 	param_quality = 0,
-	param_object_type = 1,
+	param_object_type = LOW,
 	param_mpeg = 2,
 	param_tns = 0,
 	param_raw = 0,

--HV57r+2lsJirjBrV
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
MPlayer-dev-eng mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

--HV57r+2lsJirjBrV--