Re: [PATCH] Try to adapt to recent compilers such as GCC 14

Hi/2.

Alexander Strasser wrote:
> =

> Hi komh,
> hi Ingo,
> hi all!
> =

> On 2024-10-02 21:09 +0900, KO Myung-Hun wrote:
>> Ingo Br=FCckl wrote:
>>> Lorenzo wrote on Tue, 1 Oct 2024 14:25:54 +0200:
>>>
>>>> On Tue, 01 Oct 2024 14:13:36 +0200
>>>> Ingo Br=FCckl <[email protected]> wrote:
>>>
>>>>> Lorenzo wrote on Tue, 1 Oct 2024 12:52:48 +0200:
>>>>>
>>>>>> with this patch applied it still fails[1] to build on i386 (Debian)
>>>>>> for me, with
>>>>>
>>>>>>    73 |     if (iconv(inv_msgiconv, (const char **)&filename, &filen=
ame_len,
>>>>>>       |                             ^~~~~~~~~~~~~~~~~~~~~~~~
>>>>>>       |                             |
>>>>>>       |                             const char **
>>>>>
>>>>> Which patch? It's okay in current svn.
>>>
>>>> Apologies, I was not subscribed so I just copied the subject without a
>>>> proper quote; the patch posted in
>>>> https://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2024-September/07=
4217.html
>>>
>>> This patch is broken regarding all (const char **) casts for iconv()
>>> which takes char ** as a second argument.
>>>
>>
>> Hmm... OS/2 iconv() has `const' qualifier.
>>
>> Anyway I've attached the fixed patch.
> =

> Most of the patch looks OK, besides the iconv stuff, that I need to
> look into more...
> =


Applied except iconv() parts.

Thanks.

> @komh:
> Did you try to only fix warnings that became errors recently?

Yes.

> Or did you aim for also reducing some more warnings?

Nope.


-- =

KO Myung-Hun

Korean OS/2 User Community : https://www.os2.kr/