Re: [PATCH] Fix dvdread and dvdnav is not found if --enable-static

Alexander Strasser <[email protected]> Mon, 20 Jul 2026 02:10:19 +0200
Newsgroups gmane.comp.video.mplayer.devel
Message-ID <[email protected]>
On 2026-07-07 20:24 +0900, KO Myung-Hun wrote:
> ---
>  configure | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/configure b/configure
> index b6c17ec7f..4deb3f159 100755
> --- a/configure
> +++ b/configure
> @@ -6475,6 +6475,7 @@ echores "$_bluray"
>  echocheck "dvdread"
>  if test "$_dvdread" = auto ; then
>    _dvdread=no
> +    test -n "$ld_static" && _dvdreadconfig="$_dvdreadconfig --static"
>      _dvdreadcflags=$($_dvdreadconfig --cflags 2> /dev/null)
>      _dvdreadlibs=$($_dvdreadconfig --libs 2> /dev/null)
>      if statement_check dvdread/dvd_reader.h 'DVDOpen("test")' $_dvdreadcflags $_dvdreadlibs ; then
> @@ -8414,6 +8415,7 @@ CXXFLAGS=" $CFLAGS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMI
>  echocheck "DVD support (libdvdnav)"
>  if test "$_dvdnav" = auto ; then
>    _dvdnav=no
> +  test -n "$ld_static" && _dvdnavconfig="$_dvdnavconfig --static"
>    _dvdnavdir=$($_dvdnavconfig --cflags)
>    _dvdnavlibs=$($_dvdnavconfig --libs)
>    statement_check_broken stdint.h dvdnav/dvdnav.h 'dvdnav_t *dvd = 0; dvdnav_open(&dvd, 0)' $_dvdnavdir $_dvdnavlibs $ld_dl $ld_pthread && _dvdnav=yes
> -- 

I don't really like that the path for the config programs is restricted
to not contain spaces. That has been the case before so it probably
isn't much of a problem in practice.

Thus LGTM.


  Alexander
_______________________________________________
MPlayer-dev-eng mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo/%(_internal_name)s