Re: [PATCH] bin/cue-support

Hi,

> hi,
> 
> attached is simply the reworked file, ported from main-tree.
> 
> I also removed all globals so it is a more clean approach than before.
> 
> It could also be backported to main as the g2-specific stuff is easy to see 
> :-)
> 
> Btw. I love this new stream-architecture. It is sooo nice to use :-))

and it could be ever more nice :)

static int driver_fill(stream_t *s){
  return cue_vcd_read((cue_priv_t*)s->priv,s->buffer);
}

i see no sence of such wrappers, the actual code could go into the actual
function. also, if you rename cue_priv_t to struct stream_priv_s, you will
get casting for free, ie you can access priv vars via
stream->priv->something, without extra typecasting!

also the buffer is still a static global, should be moved into the priv.
(think of parallel (threaded) use of g2 libs (hmm ok it has no much sense,
unless someone have 2 cdrom drivers and play 2 discs simultianiously:)))

and there should be no globals (exported functions) except the info struct.


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu