Re: [PATCH] bin/cue-support

Am Freitag, 23. Mai 2003 17:03 schrieb Arpi:
> Hi,
>
> > yep, who the f* does define globals all over the place in a file ?
>
> albeu? :)))
> ok it was probably me... and others copypasted it from my vcd file

no, I think cuebin-support was a PATCH by "don't remember", that was after 
some hick-hack applied into cvs.

>
> > changed :)
>
> thx
>
> > New file attached, that should solve all "problems", you spoke of.
>
> it would be better (and save some time for me) to send perfect patches at
> first time :)

ok, lets note on my list:

- use static
- use direct functions (e.g. no wrapper functions)
- use stream_priv_s (to get typecasting for free)
- change ALL global vars ;) (e.g. don't overlook some)

ok 

cat list > /dev/mind

> so i don't have to keep reviewing and commenting it until it's ok :)

heh, that was one of my first own ports from main and codebase was ugly ... :)

Hope it is ok, to review patches ?

I'll now head for trying to port mms://.

cu

Fabian

>
>
> A'rpi / Astral & ESP-team
>
> --
> Developer of MPlayer G2, the Movie Framework for all -
> http://www.MPlayerHQ.hu
>
> _______________________________________________
> MPlayer-G2-dev mailing list
> [email protected]
> http://mplayerhq.hu/mailman/listinfo/mplayer-g2-dev