Re: [PATCH] mga_vid scaler limits
Attila Kinali <[email protected]> Sun, 17 Dec 2006 00:12:12 +0100
| Newsgroups | gmane.comp.video.mplayer.devel,gmane.comp.video.mplayer.user.matrox |
|---|---|
| Organization | NERV |
| Message-ID | <[email protected]> |
On Sat, 16 Dec 2006 17:00:05 +0200 Ville Syrjälä <[email protected]> wrote: > On Sat, Dec 16, 2006 at 01:38:02PM +0200, Kalev Soikonen wrote: > > Hello > > > > Disappointed that -vo xmga would refuse 1280x720 even when scaling was unnecessary, > > I went abit poking at my matrox and the mga_vid. It appears G550 can scale larger > > frames too, provided filtering is disabled (blockiness or jaggedy edges may result, > > but it works). As long as the short dimension needs no scaling, it looks great. > > I noticed the same thing when hacking the DirectFB matrox driver. > Disabling vertical filtering allows source widths up to 2048. Note that > this only applies to G450/G550. G200 and G400 can't handle it. Why didn't anyone tell me when i added this check? Anyways. This mail belongs to -matrox as i don't have the time to scan -dev-eng regularly for intersting stuff these days. But -matrox is low traffic enough to watch closely. Fup2 mplayer-matrox > > diff -ur trunk/drivers/mga_vid.c main/drivers/mga_vid.c > > --- trunk/drivers/mga_vid.c 2006-06-05 13:29:08.000000000 +0000 > > +++ main/drivers/mga_vid.c 2006-12-14 07:58:29.000000000 +0000 Wrong tree. Have you read the README.linux.2,6 in there? It states (more or less) clearly that this tree is outdated. And i would really like that noone touches it (unless there is really a need for it) There are two places to change. The mga_vid driver in svn.mplayerhq.hu/mga_vid/mga_vid/trunk/ and the check in libvo/mga_common.c. See my last change there. But, there need to be a way to tell MPlayer that the card cannot play >1024 resolution, so that MPlayer can tell the user. I am not sure whether the current driver ioctl protocol supports this. But this is a must from my side for the patch to be appliable BTW: if you want me to apply it, you have to finish it until next friday noon (CET) or it'll have to wait until next year. Attila Kinali -- Lotus Notes ist eine verteilte Datenbankapplikation, als Sample ist eine miese Groupware dabei ;) -- Lukas Beeler