Re: Tiny patch for mga_vid to compile against 2.6.19 kernel

Tamas, Gergely wrote:
> Hi,
>
>  > Below is a tiny patch for mga_vid.c to compile against a 2.6.19 kernel.
>  > 
>  > --<CUT>---
>  > --- mga_vid-2.6.18/mga_vid.c    2006-09-27 18:32:13.000000000 +0200
>  > +++ mga_vid-2.6.19/mga_vid.c    2007-01-07 23:24:17.000000000 +0100
>  > @@ -42,7 +42,7 @@
>  > //use the 'major' parameter to override the default major number (83)
>  > /* mknod /dev/mga_vid c 83 0 */
>  > 
>  > -#include <linux/config.h>
>  > +#include <linux/autoconf.h>
>  > #include <linux/version.h>
>  > #include <linux/module.h>
>  > #include <linux/moduleparam.h>
>  > --<CUT>---
>
> Why do you need 'linux/autoconf.h' ?
>
> [dice@neptune ~]$ cat /usr/include/linux/autoconf.h
> #include <linux/err_kernel_only.h>
>
> Simply comment out the 'linux/config.h' line.
>   
It would probably be better, definitely with the version check. I tried 
to emulate the 2.6.18 linux/config.h behavior on 2.6.19 by the tiny 
patch. Maybe it's already fully obsolete and can be omitted fully.

On 2.6.18 config.h is like this:
> cat linux-2.6.18.2/include/linux/config.h

> #ifndef _LINUX_CONFIG_H
> #define _LINUX_CONFIG_H
> /* This file is no longer in use and kept only for backward compatibility.
>  * autoconf.h is now included via -imacros on the commandline
>  */
> #include <linux/autoconf.h>
>
> #endif

-- 

S pozdravem/Best Regards,
Jan Kozánek