Re: upgrade to xorg 7.2 => xmga driver broken

On Fri, 24 Aug 2007 23:16:58 +0200
Gilles Hamel <[email protected]> wrote:


Thanks a lot for the patch

> Index: libvo/mga_common.c
> ===================================================================
> --- libvo/mga_common.c  (revision 24143)
> +++ libvo/mga_common.c  (working copy)
> @@ -532,10 +532,17 @@
[...]
> +                       if (i>=0) {

Do you really mean that i becomes negative? This should not
be possible unless there is a bug in XineramaQueryScreens.


> I don't know if it's the best way to fix the issue, but it works fine here.
> Could you test with your multi-screen configuration ?

I think it should be safe for multi-screen configurations, as
the check is acutally redundand with the while loop that
tries to find the correct screen.


				Attila Kinali

-- 
Linux ist... wenn man einfache Dinge auch mit einer kryptischen
post-fix Sprache loesen kann
                        -- Daniel Hottinger