Re: [PATCH] compat-ioctl glue code to make mga_vid work for 32-bit mplayer on 64-bit kernel

Hi Attila,
Nope, no specific reason. The reasoning for putting it in was:
- I didn't delve into the rest of the module code too deeply so I don't hav=
e a good enough idea about potential race conditions there
- according to some sources on the web, classical ioctl used to run within =
the BKL and of lot of compat_ioctl conversion examples that I've seen used =
the BKL around the wrapped ioctl call
- the ioctl rate produced by mplayer seems to be fairly low, performance wi=
th and without the lock was practically identical in my tests
So I picked the "better be safe than sorry" approach. I really should have =
made a note in the source stating that I wasn't sure that the BKL was neces=
sary.

In fact, I've run a version without the BKL without any problems for some t=
ime but I figured that a single CPU single person test is not a good test f=
or race condition safeness. To wrap it up, if you're confident the locking =
isn't necessary, I'm quite happy with removing it.

Dirk



----- Urspr=FCngliche Mail ----
Von: Attila Kinali <[email protected]>
An: MPlayer on Matrox graphics cards <[email protected]>
Gesendet: Freitag, den 5. September 2008, 11:02:45 Uhr
Betreff: Re: [MPlayer-matrox] [PATCH] compat-ioctl glue code to make mga_vi=
d work for 32-bit mplayer on 64-bit kernel

On Mon, 1 Sep 2008 14:58:41 -0700 (PDT)
Dirk Porezag <[email protected]> wrote:

> +static long mga_vid_compat_ioctl (struct file *file, unsigned int cmd,
> +                                  unsigned long arg) {
> +    long ret=3D 0;
> +    lock_kernel();
> +    ret=3D (long) mga_vid_ioctl((struct inode *) NULL, file, cmd, arg);
> +    unlock_kernel();
> +    return ret;

Is there any specific reason why you use here the BKL or
locking at all?

            Attila Kinali

-- =

A strange game.
The only winning move is not to play.
            -- Joshua, WarGames
_______________________________________________
MPlayer-matrox mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-matrox


__________________________________________________
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verf=FCgt =FCber einen herausragenden Schut=
z gegen Massenmails. =

http://mail.yahoo.com =