Re: [xine-devel] Re: libdvdread and xine 1.0alpha compilation

Tue Nov 05 2002, Guenter Bartsch wrote:
> > >>	Since xine-lib don't accept any C++ comments, here is a small pathc 
> > >>	to fix comments in libdvdread (made against 0.9.3).
> > >
> > >The C++ type of comments has been in the _C-standard_ for several years
> > >now.  Is there any particualar reason why Xine doesn't allow them. It
> > >seems to me that Xine should change their compile options instead.
> > >
> > >/v
> > 
> > 	CFLAGS just change (-std=gnu89)to be Ansi C strict (no //, no 
> > 	variable declartion in a middle of a block, etc...). So, i don't 
> >     think that will change back.
> 
> actually the decision was made that the -std=gnu89 flag should not be 
> set for sources importet from external projects.
> 
If not all, then at least some of the changes, where to public headers.
These should, and will, be changed.  Though libdvdread requires GCC so
really there is not much need to support a strict Ansi 89!! conformace.
I.e. you do get lots of __attribute__ ((packed)) stuff in there anyway.

-- 
Håkan Hjort