Re: C++=>C comment, forgotten file

Mon Dec 30 2002, Martin Piskernig wrote:
> On Freitag, 27. Dezember 2002 21:21, you wrote:
> > > comments in the nav.c code for DVDTimeSearch, could the one who
> > > created the comments please explain to me how he planned to get it
> > > working? :-)
> > That would be my comments ;)
> 
> *g*
> 
> > For all the parts that one are supposed to be able to do time seeks
> > in there is a 'Time Search table' for.  it's only for parts where the
> > people how masted the DVD didn't intend one top be able too seek
> > where the more complicated method would be needed.
> 
> It seems that the time search table is not yet parsed in libdvdread 
> (from CVS)? But your output looks very much like ifo_dump so I guess 
> you have it working on your local repository? :-)
> 
Yeah, to much to do and not enough time.. have almost got to the part
where I can check that in.

> > A bit of the reason that this has been put of is that it need
> > cooperation with the GUI or one will not have any sensible way to
> > input the time to seek to.
> 
> I see two good possibilities for a GUI:
> - a slider widget going from min. 0 to max. title-time in seconds, I 
> have this working in okle (currently only for displaying position)
> - I saw AFAIR in a Goggles screenshot a dialog where you can enter 
> hh:mm:ss and then jump to that point.
> 
Slider like I'd say.. I don't think a normal slider such as used for
scrolling around windows is best, but what do I know.. 
Need to throtle the number of seek messages that is sent to Ogle some
how though I think... but lets worry about that if it turns out to be
a problem.

> > Anything in particular you'd like to do?  I think it would be
> > best/easiest to try to make the interface (dvdcontrol) work first
> > with seeking using the 'Time Search table' and then when that is
> > working possibly extending it to have alternative methods of seeking
> > (when there is no 'Time Search table').  
> 
> Could you please send me the libdvdread with the working time search 
> table? I'd really like to try to implement DVDTimeSearch in ogle.
> 
I'll send a diff to cvs as of now, and my local tree.
It contains more that that change, also be aware that the current
cvs version of libdvdread is not ABI compatible with the released version.

> > Have you looked at the
> > interface in dvdcontrol?  Does it look ok?  It's based on some other
> > interface and might not be exactly what we want, please make
> > suggestions, easiuer to change it now than later when it's used.
> 
> I'm only missing some minor functions, one of these should be a 
> DVDGetDVDInfo(...) which returns info about the current disc (disc 
> name, number of volumes, volume number etc., stuff which is at the 
> beginning of the IFO header and TXTDT (which is currently not really 
> parsed)).
> I'll write a patch for this function if you are willing to add it, the 
> info struct can be extended later with more txtdt info.
> 
Not sure what info one would like to export here.. I doubt that one
should include all the TXTDT info.
Most of the other sound good though.

-- 
Håkan Hjort