Re: a harmless typo in ifo_read.c, libdvdread

Thu Feb 19 2004, Yi-Shin Li wrote:
> I think I've found a harmless typo from line# 1633 and 1634 of 
> ifo_read.c (cvs), libdvdread.
> 
> ifoRead_PGCIT_internal():
> 
>  for(i = 0; i < pgcit->nr_of_pgci_srp; i++) {
>    memcpy(&pgcit->pgci_srp[i], ptr, PGCI_LU_SIZE); /* line# 1633 */
>    ptr += PGCI_LU_SIZE; /* line# 1634 */
>    B2N_16(pgcit->pgci_srp[i].ptl_id_mask);
>    B2N_32(pgcit->pgci_srp[i].pgc_start_byte);
>    CHECK_VALUE(pgcit->pgci_srp[i].unknown1 == 0);
>  }
> 
> Should the "PGCI_LU_SIZE" of above be "PGCI_SRP_SIZE"?
> Well, it doesn't hurt since they both are defined as 8.
> 
You're rigth, that should have been PGCI_SRP_SIZE.

Thanks
/Håkan