Re: X11 BadValue errors on Solaris 10..

On Thu, 29 Sep 2005, Bj|rn Englund wrote:

> Wed Sep 28 2005, [email protected] wrote:
>>
>
>> x: 2147483496 7fffff68,  y: 0 0, w: 1023 3ff, h: 576 240
>
>> Any ideas?
>
> Yes, this happens when the window is smaller than the "scaled" image.
> There was a bug in set_videoarea, two unsigned ints that were subtracted
> and then divided by two and then converted to a signed int.
> If the result from the subtraction was 'negative' the division made the
> resulting signed int very large.
> For some reason this worked on my Xserver anyway and on yours without xshm.
> So there must be some error correction built in or maybe there are some
> unsigned/signed/short wrap arounds in the server that 'corrects' this.
> Anyway, here is the patch (I have comitted it to CVS too)
>
> /Bj|rn

Bjorn,

Thanks for the details and for your patch. With your patch I still get a crash (albeit with different values):

ebug[ogle_mpeg_ps]: prev system_clock_reference: [9.511822 s]
Debug[ogle_mpeg_ps]: demux: changed to scr_nr: 1
dwin->win: 12582914, mygc: 713360, dwin->ximage: 713480, 0, 0,
x: -151 ffffff69,  y: 0 0, w: 1023 3ff, h: 576 240
X Error of failed request:  BadValue (integer parameter out of range for operation)
   Major opcode of failed request:  131 (MIT-SHM)
   Minor opcode of failed request:  3 (X_ShmPutImage)
   Value in failed request:  0xffffff69
   Serial number of failed request:  45
   Current serial number in output stream:  45
Debug[ogle_ctrl]: child: 4638 exited with 1 (/usr/local/lib/ogle/ogle_vout)

See the 'ffffff69'.. Any ideas?

Vincent