Re: [patch] video deinterlacing support

Sun Jul 28 2002, Pierre Lombard wrote:
> Hi,
> 
> The patch attached is a quick hack to deinterlace DVDs based on
> xine-lib/src/video_out/deinterlace.[hc] (mmx optimized 0.9.12).
> 
> They are slightly edited to compile with ogle 0.8.4 (so a resync will be
> possible very easily).
> 
We haven't doen this before because there is so much more to
deinterlacing than just doing bob/weave/average/scaling.  Certanly
deciding when it's needed is one thing, and trying to tell when some
fields should just be dropped to get back a progressive source.

Though I guess this will let people stand to watch interlaced material
with out getting serious eye injuries ;)

I suppose that keeping it close to the xine/dscaler source will make
updates easier but that code has some issues...

> Deinterlacing is currently hardcoded in
> ogle/mpeg2_video/video_output_x11.c but it would be better to add some
> hooks or an API to set it with ogle_gui, which I've not done 8)
>
Indeed, not very usefull if it's always on (or off) becuase most
matterial is already progressive and will only get worse by
deinterlacing.
You could look at the Zoom setting for an example of how to pass info
from the gui to the video out part (though the gui has no code to call
those functions it should be easy to add ;).

> NB: linear blend should not be used as with fixed images (in menus), the
> picture is smoothed again & again.
> 
This is not a good solution.  Indeed we should try to avoid the extra
memmory copies that were introduced by this.  I belive that still
images never should be deinterlaced, but I could be wrong here.

Depending of whether the last field or the last frame is to be
repeated.  If it's 'frame' then it must be pogressive or it would
cause flicker on a normal TV too.

-- 
Håkan Hjort