War on magic numbers

    Too many places in the codebase have "magic numbers": hard-coded 
constants that should really be replaced with #define'd values or 
enum'ed values.  A few questions:

o do you prefer #define'd values or enums?

o should I create a separete dvdread/constants.h or should I place the 
values in the header file that matches the .c file in which they're 
contained (e.g., FPS_2500 and FPS_2997 go in ifo_print.h or should I put 
everything in *_types.h?

o what is the patch submission process?

Thanks.
-jdm

Department of Computer Science, Duke University, Durham, NC 27708-0129
Email:	[email protected]
Web:	http://www.cs.duke.edu/~justin/