Re: War on magic numbers

--=-j1+xOJgR5lW2vMGHInf5
Content-Type: text/plain
Content-Transfer-Encoding: 7bit


> > o what is the patch submission process?
> > 
> 
> Send the patches to the ogle-devel list.
> (Keep them small, don't submit unrelated changes in the same patch,
> everything should compile after each patch is applied)

Here's the first patch that creates the named constants for IFO data
using #define's.  Let me know if any names should be changed.

-jdm

-- 
Department of Computer Science, Duke University, Durham, NC 27708-0129
Email:  [email protected]
Web:    http://www.cs.duke.edu/~justin/

--=-j1+xOJgR5lW2vMGHInf5
Content-Disposition: attachment; filename=ifo_magic_numbers_header.patch
Content-Type: text/x-patch; name=ifo_magic_numbers_header.patch; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Index: ifo_types.h
===================================================================
RCS file: /cvsroot/ogle/libdvdread/dvdread/ifo_types.h,v
retrieving revision 1.18
diff -u -r1.18 ifo_types.h
--- ifo_types.h	2 Mar 2006 17:25:43 -0000	1.18
+++ ifo_types.h	13 Nov 2006 01:49:04 -0000
@@ -71,6 +71,9 @@
   uint8_t frame_u; /* The two high bits are the frame rate. */
 } ATTRIBUTE_PACKED dvd_time_t;
 
+#define DVDREAD_FPS_2500 1
+#define DVDREAD_FPS_2997 3
+
 /**
  * Type to store per-command data.
  */
@@ -115,6 +118,33 @@
 #endif
 } ATTRIBUTE_PACKED video_attr_t;
 
+#define DVDREAD_MPEG_VERSION1 0
+#define DVDREAD_MPEG_VERSION2 1
+
+#define DVDREAD_FORMAT_NTSC 0
+#define DVDREAD_FORMAT_PAL  1
+
+#define DVDREAD_ASPECT_4x3  0
+#define DVDREAD_ASPECT_16x9 3
+
+#define DVDREAD_SCREEN_PANSCAN_LBOX 0
+#define DVDREAD_SCREEN_PANSCAN_ONLY 1
+#define DVDREAD_SCREEN_LBOX_ONLY    2
+
+#define DVDREAD_ENCODING_VARIABLE 0
+#define DVDREAD_ENCODING_CONSTANT 1
+
+#define DVDREAD_PICTURE_OVERSCAN_720   0
+#define DVDREAD_PICTURE_EXACTSCAN_704  1
+#define DVDREAD_PICTURE_FULLHEIGHT_352 2
+#define DVDREAD_PICTURE_HALFHEIGHT_352 3
+
+#define DVDREAD_LETTERBOXED_NO     0
+#define DVDREAD_LETTERBOXED_SOURCE 1
+
+#define DVDREAD_FILMMODE_VIDEO 0
+#define DVDREAD_FILMMODE_FILM  1
+
 /**
  * Audio Attributes.
  */
@@ -174,6 +204,41 @@
   } ATTRIBUTE_PACKED app_info;
 } ATTRIBUTE_PACKED audio_attr_t;
 
+#define DVDREAD_AUDIO_AC3      0
+#define DVDREAD_AUDIO_UNKNOWN1 1
+#define DVDREAD_AUDIO_MPEG1    2
+#define DVDREAD_AUDIO_MPEG2EXT 3
+#define DVDREAD_AUDIO_LPCM     4
+#define DVDREAD_AUDIO_UNKNOWN5 5
+#define DVDREAD_AUDIO_DTS      6
+
+#define DVDREAD_LANGTYPE_UNSPECIFIED 0
+#define DVDREAD_LANGTYPE_SPECIFIED   1
+
+#define DVDREAD_AUDIOMODE_UNSPECIFIED 0
+#define DVDREAD_AUDIOMODE_KARAOKE     1
+#define DVDREAD_AUDIOMODE_SURROUND    2
+
+#define DVDREAD_QUANT_AC3_VALID 3
+
+#define DVDREAD_QUANT_MPEG_NODRC 0
+#define DVDREAD_QUANT_MPEG_DRC   1
+
+#define DVDREAD_QUANT_LPCM_16BIT   0
+#define DVDREAD_QUANT_LPCM_20BIT   1
+#define DVDREAD_QUANT_LPCM_24BIT   2
+#define DVDREAD_QUANT_LPCM_INVALID 3
+
+#define DVDREAD_QUANT_DTS_VALID 3
+
+#define DVDREAD_AUDIOFREQ_48KHZ 0
+#define DVDREAD_AUDIOFREQ_96KHZ 1
+
+#define DVDREAD_AUDIOCODE_EXT_UNSPECIFIED 0
+#define DVDREAD_AUDIOCODE_EXT_NORMAL      1
+#define DVDREAD_AUDIOCODE_EXT_VISIMPAIR   2
+#define DVDREAD_AUDIOCODE_EXT_DIRECTOR1   3
+#define DVDREAD_AUDIOCODE_EXT_DIRECTOR2   4
 
 /**
  * MultiChannel Extension
@@ -261,6 +326,29 @@
   uint8_t  code_extension;
 } ATTRIBUTE_PACKED subp_attr_t;
 
+#define DVDREAD_SUBPIC_TYPE_UNSPECIFIED 0
+#define DVDREAD_SUBPIC_TYPE_LANG        1
+#define DVDREAD_SUBPIC_TYPE_OTHER       2
+
+#define DVDREAD_SUBPIC_ENCODING_RLE 0
+#define DVDREAD_SUBPIC_ENCODING_EXT 1
+
+#define DVDREAD_SUBPIC_CODE_UNSPECIFIED       0
+#define DVDREAD_SUBPIC_CODE_CAPTION_NORMAL    1
+#define DVDREAD_SUBPIC_CODE_CAPTION_LARGE     2
+#define DVDREAD_SUBPIC_CODE_CAPTION_CHILDREN  3
+#define DVDREAD_SUBPIC_CODE_RESERVED4         4
+#define DVDREAD_SUBPIC_CODE_CLOSCAP_NORMAL    5
+#define DVDREAD_SUBPIC_CODE_CLOSCAP_LARGE     6
+#define DVDREAD_SUBPIC_CODE_CLOSCAP_CHILDREN  7
+#define DVDREAD_SUBPIC_CODE_RESERVED8         8
+#define DVDREAD_SUBPIC_CODE_FORCED_CAPTION    9
+#define DVDREAD_SUBPIC_CODE_RESERVED10       10
+#define DVDREAD_SUBPIC_CODE_RESERVED11       11
+#define DVDREAD_SUBPIC_CODE_RESERVED12       12
+#define DVDREAD_SUBPIC_CODE_DIRCOMM_NORMAL   13
+#define DVDREAD_SUBPIC_CODE_DIRCOMM_LARGE    14
+#define DVDREAD_SUBPIC_CODE_DIRCOMM_CHILDREN 15
 
 
 /**

--=-j1+xOJgR5lW2vMGHInf5
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Ogle-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/ogle-devel

--=-j1+xOJgR5lW2vMGHInf5--