Re: "Patch" libdvdread.

Hello Hakan,

Thanks for a quick answer,

--- H}kan Hjort <[email protected]> wrote:
[snip]
> > The case is that dvdread doesn't export the whole
> ifo structure some
> > small parts are missing. It's offset tables ...
> 
> Do you really want them?  I gues they only matter if
> you want to make
> minimal non-intrusive edits.  The are just the
> offsets to were the
> info is stored.  When you layout the suff in the IFO
> file you createt
> just make up new offsets that will work for the data
> you generate.

You hit the nail - I want to be able to do minimal
non-intrusive edits. This is about doing it the right
way (tm) and preserve as much as possible of a
structure. In the case that I make very small changes.


> > and the time map in the VTS IFO that I main issues
> 
> I've actually just implemented this, see current cvs
>
(http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ogle/libdvdread/)

Ahh, nice and how do I do a anon cvs checkout of the
latest and greatest :) dvdread. 
 
> > although I have also bumped into some incorrect
> things. 
> > Anyhow I have attached a patch for ifo_types.h
> that will "export" all
> > I need for ifoedit.
> >
> The audio extensions stuff wasn't exactly a clean
> addition.
> Where is that information derived from?   Having a
> bunch of pointers
> in the ifo_handle_t instead of at the end of the
> vmgi_mat_t and 
> vtsi_mat_t was to share the common ones (and it
> looked a bit cleaner).

Nope it for sure wasn't but I didn't really see where
to put it without trashing your structres. Which I
ended up doing after all later on. I got the info from
mpucoder and ifoedit, and reading DVD Demystified. I'm
not totally happy with it since there is a lot of
questions marks at least in my view but it's a start.
 
> The TMAPT changes clash with my implementation, and
> again do you really need the extra offsets?

Yes, I think they are important due to the fact that I
want to be able to do small edits without changing the
layout.

> > My question is if you as dvdread developer are
> happy with my
> > additions to the structure, may be you have
> questions, suggestions,
> > or want to alter it a bit etc. After the structure
> is sorted out I
> > will go a head and implement the changes to
> libdvdread but I think
> > it was a good idea to start with the types so we
> are on the same
> > line so to say rather than me sending in a bigger
> patch in one
> > chunk.
> > 
> Very good plan.
> Depending on how you look at it, you now have to
> redo some work with
> fixing the ifo_types.h again for my TMAPT changes,
> on the other hand
> I've already written the ifo_read / ifo_print
> changes.


I kind of counted that there would be suggestions,
comments etc. hence my header changes was a one eveing
quick hack from notes I made during the dev of
ifoedits "ifo type" headers. My question is are you
okay with my additions if I make them work? I
understand that you hold your reservations for the
audio multi channel extensions so I can skip that one
for the moment? If so I will download the CVS version
and start implementing. 



> > PS: I'm working on the VMG_TXTDT_MG structure but
> there are many
> > black holes that need to be filled in before it's
> ready - any hints
> > or more docs regards to it is very welcomed.
> 
> Have a look at the documentation on microsofts
> developer pages for there
> DVD player api.  It seems to be very close to the on
> disc format.

Thanks for the tip!!

> 
> We have a few (two or three) DVDs that have TXTDT if
> you need more examples.

Thanks for the offer can you possible send me the
VIDEO_TS.IFO files along with a note about what disk
you got each from. Ahh, while I'm on it you don't have
any karaoke DVD's ??

Cheers Olaf 


__________________________________________________
Do You Yahoo!?
HotJobs - Search Thousands of New Jobs
http://www.hotjobs.com