Re: C++11, 'throw', etc.
Piotr Stanczyk <[email protected]> Thu, 10 Aug 2017 18:52:12 +0000
| Newsgroups | gmane.comp.video.openexr.devel |
|---|---|
| Message-ID | <CALVgk2rhT4nn_umqm5zUKR3cyiTYaLCS3Ej+TEpDodBF96yVGQ@mail.gmail.com> |
--===============1666210725698421765== Content-Type: multipart/alternative; boundary="001a113d3c385d34e005566ab234" --001a113d3c385d34e005566ab234 Content-Type: text/plain; charset="UTF-8" Sounds like a sensible plan to me. Anyone from ILM care to comment on this? Can you foresee any internal build issues? Piotr On Thu, Aug 10, 2017 at 11:40 AM Larry Gritz <[email protected]> wrote: > Any vendors that have bought into VFX Platform (Autodesk, Foundry, SESI) > should in theory have been on C++11 since last year (and should be on board > for C++14 for any products coming in 2018). > > We're only talking about moving forward, so a stray downstream product > stuck on C++03 can keep using OpenEXR <= 2.2. > > I'll give it a couple days to see if there are objections before I do any > of the actual work. But it will be cleaner and easier if we can just assume > C++11 as a minimum. > > -- lg > > > On Aug 10, 2017, at 11:12 AM, Piotr Stanczyk <[email protected]> > wrote: > > Are there any vendors for whom this would cause an issue? Else, I would > vote for moving things forward > > > On 10 August 2017 at 10:18, Larry Gritz <[email protected]> wrote: > >> Ugh, so it's worse than I thought. >> >> I suppose I'm willing to fix and submit a patch to address this. >> >> Do I need to put in the proper macros to make it compile on everything >> from C++03 through 17? Does anybody want to argue for continuing to >> maintain C++03 compatibility for future OpenEXR releases, or is it finally >> time (six years after the C++ standard and 2+ years after VFXPlatform) to >> raise the floor to C++11? >> >> -- lg >> >> >> On Aug 9, 2017, at 11:38 PM, Werner Benger <[email protected]> wrote: >> >> It should be noted that dynamic expressions are actually forbidden in >> C++17, so OpenEXR does no longer compile with GCC 7.1 when std C++17 is >> enabled. The highest C++ version that can be used to compile it is C++14, >> where it's still just a warning, while in C++17 it's an error. It would be >> good to have OpenEXR at least compilable in C++17. Major C++ libraries >> such as QT are using C++11 nowadays, so it seems pretty safe to go beyond >> C++03 for modern applications, a lot of things are indeed much easier. >> >> Werner >> >> >> On 10.08.2017 00:20, Larry Gritz wrote: >> >> In a test compile with gcc 7, I get lots of errors of the following ilk: >> >> /home/travis/build/lgritz/openexr/IlmBase/Imath/ImathVec.h:228:34: >> warning: dynamic exception specifications are deprecated in C++11 >> [-Wdeprecated] >> const Vec2 & normalizeExc () throw (IEX_NAMESPACE::MathExc); >> ^~~~~ >> >> I can disable this particular warning, of course, but it's worth noting >> that the OpenEXR code base is not C++11 compliant. But in addition to using >> some C++03 idioms that are deprecated in C++11, perhaps more importantly, >> the code is not taking advantage of new features such as move semantics, >> constexpr, nothrow, and others. For the Imath classes especially, using >> some of these may actually confer a performance benefit. >> >> I feel kind of bad pointing this out while not really having the time at >> the moment to code up and submit an actual patch myself, but I thought I'd >> at least open the topic and see where the community stands on the issue of >> how and when to upgrade to C++11 and if it's important for modern OpenEXR >> to continue to support C++03. For point of reference, the VFX Reference >> Platform [http://www.vfxplatform.com/] dictated C++11 for 2016 and 2017, >> and will be C++14 for 2018. >> >> -- lg >> >> -- >> Larry Gritz >> [email protected] >> >> >> >> >> >> _______________________________________________ >> Openexr-devel mailing list >> [email protected] >> https://lists.nongnu.org/mailman/listinfo/openexr-devel >> >> >> -- >> >> ___________________________________________________________________________ >> Dr. Werner Benger Visualization Research >> Center for Computation & Technology at Louisiana State University >> (CCT/LSU) >> 2019 Digital Media Center, Baton Rouge, Louisiana 70803 >> Tel.: +1 225 578 4809 <(225)%20578-4809> Fax.: +1 >> 225 578-5362 <(225)%20578-5362> >> >> >> _______________________________________________ >> Openexr-devel mailing list >> [email protected] >> https://lists.nongnu.org/mailman/listinfo/openexr-devel >> >> >> -- >> Larry Gritz >> [email protected] >> >> >> >> >> >> _______________________________________________ >> Openexr-devel mailing list >> [email protected] >> https://lists.nongnu.org/mailman/listinfo/openexr-devel >> >> > > -- > Larry Gritz > [email protected] > > > > > --001a113d3c385d34e005566ab234 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div>Sounds like a sensible plan to me.=C2=A0</div><div><br></div><div>Anyo= ne from ILM care to comment on this? Can you foresee any internal build iss= ues?</div><div><br></div><div>Piotr</div><div><br><div class=3D"gmail_quote= "><div>On Thu, Aug 10, 2017 at 11:40 AM Larry Gritz <<a href=3D"mailto:l= [email protected]">[email protected]</a>> wrote:<br></div><blockquote cla= ss=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pa= dding-left:1ex"><div style=3D"word-wrap:break-word">Any vendors that have b= ought into VFX Platform (Autodesk, Foundry, SESI) should in theory have bee= n on C++11 since last year (and should be on board for C++14 for any produc= ts coming in 2018).<div><br></div><div>We're only talking about moving = forward, so a stray downstream product stuck on C++03 can keep using OpenEX= R <=3D 2.2.</div><div><br></div><div>I'll give it a couple days to s= ee if there are objections before I do any of the actual work. But it will = be cleaner and easier if we can just assume C++11 as a minimum.</div><div><= br></div><div><span class=3D"m_-6079636075028917681Apple-tab-span" style=3D= "white-space:pre-wrap"> </span>-- lg</div><div><br><div></div></div></div><= div style=3D"word-wrap:break-word"><div><div><br><div><blockquote type=3D"c= ite"><div>On Aug 10, 2017, at 11:12 AM, Piotr Stanczyk <<a href=3D"mailt= o:[email protected]" target=3D"_blank">[email protected]</a>&= gt; wrote:</div><br class=3D"m_-6079636075028917681Apple-interchange-newlin= e"><div><div>Are there any vendors for whom this would cause an issue? Else= , I would vote for moving things forward=C2=A0<div><br></div></div><div cla= ss=3D"gmail_extra"><br><div class=3D"gmail_quote">On 10 August 2017 at 10:1= 8, Larry Gritz <span><<a href=3D"mailto:[email protected]" target=3D"_bl= ank">[email protected]</a>></span> wrote:<br><blockquote class=3D"gmail_= quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1= ex"><div style=3D"word-wrap:break-word">Ugh, so it's worse than I thoug= ht.<div><br></div><div>I suppose I'm willing to fix and submit a patch = to address this.</div><div><br></div><div>Do I need to put in the proper ma= cros to make it compile on everything from C++03 through 17? Does anybody w= ant to argue for continuing to maintain C++03 compatibility for future Open= EXR releases, or is it finally time (six years after the C++ standard and 2= + years after VFXPlatform) to raise the floor to C++11?</div><div><br></div= ><div><span class=3D"m_-6079636075028917681m_6758675243403444048Apple-tab-s= pan" style=3D"white-space:pre-wrap"> </span>-- lg</div><div><br></div><div>= <div><div class=3D"m_-6079636075028917681h5"><br><div><blockquote type=3D"c= ite"><div>On Aug 9, 2017, at 11:38 PM, Werner Benger <<a href=3D"mailto:= [email protected]" target=3D"_blank">[email protected]</a>> wrote:</di= v><br class=3D"m_-6079636075028917681m_6758675243403444048Apple-interchange= -newline"><div><div>It should be noted that dynamic expressions are actuall= y forbidden in C++17, so OpenEXR does no longer compile with GCC 7.1 when s= td C++17 is enabled. The highest C++ version that can be used to compile it= is C++14, where it's still just a warning, while in C++17 it's an = error. It would be good to have OpenEXR at least compilable in C++17.=C2=A0= Major C++ libraries such as QT are using C++11 nowadays, so it seems prett= y safe to go beyond C++03 for modern applications, a lot of things are inde= ed much easier.<br><br> =C2=A0=C2=A0=C2=A0=C2=A0Werner<br><br><br>On 10.08.= 2017 00:20, Larry Gritz wrote:<br><blockquote type=3D"cite">In a test compi= le with gcc 7, I get lots of errors of the following ilk:<br><br>/home/trav= is/build/lgritz/openexr/IlmBase/Imath/ImathVec.h:228:34: warning: dynamic e= xception specifications are deprecated in C++11 [-Wdeprecated]<br> =C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0const Vec2 & normalizeExc () throw (IEX_NAMESPA= CE::MathExc);<br> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0^~~= ~~<br><br>I can disable this particular warning, of course, but it's wo= rth noting that the OpenEXR code base is not C++11 compliant. But in additi= on to using some C++03 idioms that are deprecated in C++11, perhaps more im= portantly, the code is not taking advantage of new features such as move se= mantics, constexpr, nothrow, and others. For the Imath classes especially, = using some of these may actually confer a performance benefit.<br><br>I fee= l kind of bad pointing this out while not really having the time at the mom= ent to code up and submit an actual patch myself, but I thought I'd at = least open the topic and see where the community stands on the issue of how= and when to upgrade to C++11 and if it's important for modern OpenEXR = to continue to support C++03. For point of reference, the VFX Reference Pla= tform [<a href=3D"http://www.vfxplatform.com/" target=3D"_blank">http://www= .vfxplatform.com/</a>] dictated C++11 for 2016 and 2017, and will be C++14 = for 2018.<br><br><span class=3D"m_-6079636075028917681m_6758675243403444048= Apple-tab-span" style=3D"white-space:pre-wrap"> </span>-- lg<br><br>--<br>L= arry Gritz<br><a href=3D"mailto:[email protected]" target=3D"_blank">lg@lar= rygritz.com</a><br><br><br><br><br><br>____________________________________= ___________<br>Openexr-devel mailing list<br><a href=3D"mailto:Openexr-deve= [email protected]" target=3D"_blank">[email protected]</a><br><a href=3D"= https://lists.nongnu.org/mailman/listinfo/openexr-devel" target=3D"_blank">= https://lists.nongnu.org/mailman/listinfo/openexr-devel</a><br></blockquote= ><br>-- <br>_______________________________________________________________= ____________<br>Dr. Werner Benger =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Visualization Research<b= r>Center for Computation & Technology at Louisiana State University (CC= T/LSU)<br>2019 =C2=A0Digital Media Center, Baton Rouge, Louisiana 70803<br>= Tel.: <a href=3D"tel:(225)%20578-4809" value=3D"+12255784809" target=3D"_bl= ank">+1 225 578 4809</a> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0Fax.: <a href=3D"tel:(225)%20578-5362" value=3D"+12255785362= " target=3D"_blank">+1 225 578-5362</a><br><br><br>________________________= _______________________<br>Openexr-devel mailing list<br><a href=3D"mailto:= [email protected]" target=3D"_blank">[email protected]</a><br= ><a href=3D"https://lists.nongnu.org/mailman/listinfo/openexr-devel" target= =3D"_blank">https://lists.nongnu.org/mailman/listinfo/openexr-devel</a><br>= </div></div></blockquote></div><br></div></div><div> <div style=3D"word-wrap:break-word"><div style=3D"font-family:Helvetica;fon= t-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;l= etter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;w= hite-space:normal;word-spacing:0px">--</div><div style=3D"font-family:Helve= tica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:= normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transfor= m:none;white-space:normal;word-spacing:0px">Larry Gritz</div><div style=3D"= font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:no= rmal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:= 0px;text-transform:none;white-space:normal;word-spacing:0px"><a href=3D"mai= lto:[email protected]" target=3D"_blank">[email protected]</a></div><div st= yle=3D"font-family:Helvetica;font-size:14px;font-style:normal;font-variant-= caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-= indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br></d= iv><br class=3D"m_-6079636075028917681m_6758675243403444048Apple-interchang= e-newline"></div><br class=3D"m_-6079636075028917681m_6758675243403444048Ap= ple-interchange-newline"> </div> <br></div></div><br>_______________________________________________<br> Openexr-devel mailing list<br> <a href=3D"mailto:[email protected]" target=3D"_blank">Openexr-devel= @nongnu.org</a><br> <a href=3D"https://lists.nongnu.org/mailman/listinfo/openexr-devel" rel=3D"= noreferrer" target=3D"_blank">https://lists.nongnu.org/mailman/listinfo/ope= nexr-devel</a><br> <br></blockquote></div><br></div> </div></blockquote></div><br></div></div></div><div style=3D"word-wrap:brea= k-word"><div><div><div> <div style=3D"word-wrap:break-word"><div style=3D"color:rgb(0,0,0);font-fam= ily:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;fon= t-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text= -transform:none;white-space:normal;word-spacing:0px">--</div><div style=3D"= color:rgb(0,0,0);font-family:Helvetica;font-size:14px;font-style:normal;fon= t-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:s= tart;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0p= x">Larry Gritz</div><div style=3D"color:rgb(0,0,0);font-family:Helvetica;fo= nt-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;= letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;= white-space:normal;word-spacing:0px"><a href=3D"mailto:[email protected]" t= arget=3D"_blank">[email protected]</a></div><div style=3D"color:rgb(0,0,0);= font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:no= rmal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:= 0px;text-transform:none;white-space:normal;word-spacing:0px"><br></div><br = class=3D"m_-6079636075028917681Apple-interchange-newline"></div><br class= =3D"m_-6079636075028917681Apple-interchange-newline"> </div> <br></div></div></div></blockquote></div></div> --001a113d3c385d34e005566ab234-- --===============1666210725698421765== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openexr-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/openexr-devel --===============1666210725698421765==--