Re: C++11, 'throw', etc.
Nick Rasmussen <[email protected]> Fri, 11 Aug 2017 23:20:54 +0000
| Newsgroups | gmane.comp.video.openexr.devel |
|---|---|
| Message-ID | <CAOYGd5xVd3obUtAtpdEBouXNEnfhGdd=b9znaGPf875HaG4GSQ@mail.gmail.com> |
--===============3734369925726064652== Content-Type: multipart/alternative; boundary="f403045eb0823a2cdc055682913c" --f403045eb0823a2cdc055682913c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable It seems reasonable to me as well. Removing the dynamic exception specifications would=E2=80=99t even break compatibility with older compiler= s. -nick On Thu, Aug 10, 2017 at 11:52 AM Piotr Stanczyk <[email protected]> wrote: > Sounds like a sensible plan to me. > > Anyone from ILM care to comment on this? Can you foresee any internal > build issues? > > Piotr > > On Thu, Aug 10, 2017 at 11:40 AM Larry Gritz <[email protected]> wrote: > >> Any vendors that have bought into VFX Platform (Autodesk, Foundry, SESI) >> should in theory have been on C++11 since last year (and should be on bo= ard >> for C++14 for any products coming in 2018). >> >> We're only talking about moving forward, so a stray downstream product >> stuck on C++03 can keep using OpenEXR <=3D 2.2. >> >> I'll give it a couple days to see if there are objections before I do an= y >> of the actual work. But it will be cleaner and easier if we can just ass= ume >> C++11 as a minimum. >> >> -- lg >> >> >> On Aug 10, 2017, at 11:12 AM, Piotr Stanczyk <[email protected]> >> wrote: >> >> Are there any vendors for whom this would cause an issue? Else, I would >> vote for moving things forward >> >> >> On 10 August 2017 at 10:18, Larry Gritz <[email protected]> wrote: >> >>> Ugh, so it's worse than I thought. >>> >>> I suppose I'm willing to fix and submit a patch to address this. >>> >>> Do I need to put in the proper macros to make it compile on everything >>> from C++03 through 17? Does anybody want to argue for continuing to >>> maintain C++03 compatibility for future OpenEXR releases, or is it fina= lly >>> time (six years after the C++ standard and 2+ years after VFXPlatform) = to >>> raise the floor to C++11? >>> >>> -- lg >>> >>> >>> On Aug 9, 2017, at 11:38 PM, Werner Benger <[email protected]> wrote: >>> >>> It should be noted that dynamic expressions are actually forbidden in >>> C++17, so OpenEXR does no longer compile with GCC 7.1 when std C++17 is >>> enabled. The highest C++ version that can be used to compile it is C++1= 4, >>> where it's still just a warning, while in C++17 it's an error. It would= be >>> good to have OpenEXR at least compilable in C++17. Major C++ libraries >>> such as QT are using C++11 nowadays, so it seems pretty safe to go beyo= nd >>> C++03 for modern applications, a lot of things are indeed much easier. >>> >>> Werner >>> >>> >>> On 10.08.2017 00:20, Larry Gritz wrote: >>> >>> In a test compile with gcc 7, I get lots of errors of the following ilk= : >>> >>> /home/travis/build/lgritz/openexr/IlmBase/Imath/ImathVec.h:228:34: >>> warning: dynamic exception specifications are deprecated in C++11 >>> [-Wdeprecated] >>> const Vec2 & normalizeExc () throw (IEX_NAMESPACE::MathExc); >>> ^~~~~ >>> >>> I can disable this particular warning, of course, but it's worth noting >>> that the OpenEXR code base is not C++11 compliant. But in addition to u= sing >>> some C++03 idioms that are deprecated in C++11, perhaps more importantl= y, >>> the code is not taking advantage of new features such as move semantics= , >>> constexpr, nothrow, and others. For the Imath classes especially, using >>> some of these may actually confer a performance benefit. >>> >>> I feel kind of bad pointing this out while not really having the time a= t >>> the moment to code up and submit an actual patch myself, but I thought = I'd >>> at least open the topic and see where the community stands on the issue= of >>> how and when to upgrade to C++11 and if it's important for modern OpenE= XR >>> to continue to support C++03. For point of reference, the VFX Reference >>> Platform [http://www.vfxplatform.com/] dictated C++11 for 2016 and >>> 2017, and will be C++14 for 2018. >>> >>> -- lg >>> >>> -- >>> Larry Gritz >>> [email protected] >>> >>> >>> >>> >>> >>> _______________________________________________ >>> Openexr-devel mailing list >>> [email protected] >>> https://lists.nongnu.org/mailman/listinfo/openexr-devel >>> >>> >>> -- >>> >>> _______________________________________________________________________= ____ >>> Dr. Werner Benger Visualization Research >>> Center for Computation & Technology at Louisiana State University >>> (CCT/LSU) >>> 2019 Digital Media Center, Baton Rouge, Louisiana 70803 >>> Tel.: +1 225 578 4809 <(225)%20578-4809> Fax.: += 1 >>> 225 578-5362 <(225)%20578-5362> >>> >>> >>> _______________________________________________ >>> Openexr-devel mailing list >>> [email protected] >>> https://lists.nongnu.org/mailman/listinfo/openexr-devel >>> >>> >>> -- >>> Larry Gritz >>> [email protected] >>> >>> >>> >>> >>> >>> _______________________________________________ >>> Openexr-devel mailing list >>> [email protected] >>> https://lists.nongnu.org/mailman/listinfo/openexr-devel >>> >>> >> >> -- >> Larry Gritz >> [email protected] >> >> >> >> >> _______________________________________________ > Openexr-devel mailing list > [email protected] > https://lists.nongnu.org/mailman/listinfo/openexr-devel > --f403045eb0823a2cdc055682913c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div><div dir=3D"auto"><br></div><div><div dir=3D"auto">It seems reasonable= to me as well.=C2=A0 Removing the dynamic exception specifications would= =E2=80=99t even break compatibility with older compilers.=C2=A0</div></div>= </div><div><div><div dir=3D"auto"><br></div><div dir=3D"auto">-nick</div></= div><div><br><div class=3D"gmail_quote"><div>On Thu, Aug 10, 2017 at 11:52 = AM Piotr Stanczyk <<a href=3D"mailto:[email protected]" target=3D= "_blank">[email protected]</a>> wrote:<br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd= ing-left:1ex"><div>Sounds like a sensible plan to me.=C2=A0</div><div><br><= /div><div>Anyone from ILM care to comment on this? Can you foresee any inte= rnal build issues?</div><div><br></div><div>Piotr</div><div><br><div class= =3D"gmail_quote"><div>On Thu, Aug 10, 2017 at 11:40 AM Larry Gritz <<a h= ref=3D"mailto:[email protected]" target=3D"_blank">[email protected]</a>>= ; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .= 8ex;border-left:1px #ccc solid;padding-left:1ex"><div style=3D"word-wrap:br= eak-word">Any vendors that have bought into VFX Platform (Autodesk, Foundry= , SESI) should in theory have been on C++11 since last year (and should be = on board for C++14 for any products coming in 2018).<div><br></div><div>We&= #39;re only talking about moving forward, so a stray downstream product stu= ck on C++03 can keep using OpenEXR <=3D 2.2.</div><div><br></div><div>I&= #39;ll give it a couple days to see if there are objections before I do any= of the actual work. But it will be cleaner and easier if we can just assum= e C++11 as a minimum.</div><div><br></div><div><span class=3D"m_63619441204= 89933342m_-293618947442915972m_-6079636075028917681Apple-tab-span" style=3D= "white-space:pre-wrap"> </span>-- lg</div><div><br><div></div></div></div><= div style=3D"word-wrap:break-word"><div><div><br><div><blockquote type=3D"c= ite"><div>On Aug 10, 2017, at 11:12 AM, Piotr Stanczyk <<a href=3D"mailt= o:[email protected]" target=3D"_blank">[email protected]</a>&= gt; wrote:</div><br class=3D"m_6361944120489933342m_-293618947442915972m_-6= 079636075028917681Apple-interchange-newline"><div><div>Are there any vendor= s for whom this would cause an issue? Else, I would vote for moving things = forward=C2=A0<div><br></div></div><div class=3D"gmail_extra"><br><div class= =3D"gmail_quote">On 10 August 2017 at 10:18, Larry Gritz <span><<a href= =3D"mailto:[email protected]" target=3D"_blank">[email protected]</a>></= span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8e= x;border-left:1px #ccc solid;padding-left:1ex"><div style=3D"word-wrap:brea= k-word">Ugh, so it's worse than I thought.<div><br></div><div>I suppose= I'm willing to fix and submit a patch to address this.</div><div><br><= /div><div>Do I need to put in the proper macros to make it compile on every= thing from C++03 through 17? Does anybody want to argue for continuing to m= aintain C++03 compatibility for future OpenEXR releases, or is it finally t= ime (six years after the C++ standard and 2+ years after VFXPlatform) to ra= ise the floor to C++11?</div><div><br></div><div><span class=3D"m_636194412= 0489933342m_-293618947442915972m_-6079636075028917681m_6758675243403444048A= pple-tab-span" style=3D"white-space:pre-wrap"> </span>-- lg</div><div><br><= /div><div><div><div class=3D"m_6361944120489933342m_-293618947442915972m_-6= 079636075028917681h5"><br><div><blockquote type=3D"cite"><div>On Aug 9, 201= 7, at 11:38 PM, Werner Benger <<a href=3D"mailto:[email protected]" tar= get=3D"_blank">[email protected]</a>> wrote:</div><br class=3D"m_636194= 4120489933342m_-293618947442915972m_-6079636075028917681m_67586752434034440= 48Apple-interchange-newline"><div><div>It should be noted that dynamic expr= essions are actually forbidden in C++17, so OpenEXR does no longer compile = with GCC 7.1 when std C++17 is enabled. The highest C++ version that can be= used to compile it is C++14, where it's still just a warning, while in= C++17 it's an error. It would be good to have OpenEXR at least compila= ble in C++17.=C2=A0 Major C++ libraries such as QT are using C++11 nowadays= , so it seems pretty safe to go beyond C++03 for modern applications, a lot= of things are indeed much easier.<br><br> =C2=A0=C2=A0=C2=A0=C2=A0Werner<b= r><br><br>On 10.08.2017 00:20, Larry Gritz wrote:<br><blockquote type=3D"ci= te">In a test compile with gcc 7, I get lots of errors of the following ilk= :<br><br>/home/travis/build/lgritz/openexr/IlmBase/Imath/ImathVec.h:228:34:= warning: dynamic exception specifications are deprecated in C++11 [-Wdepre= cated]<br> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0const Vec2 & normalizeExc () t= hrow (IEX_NAMESPACE::MathExc);<br> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0^~~~~<br><br>I can disable this particular warning, of cours= e, but it's worth noting that the OpenEXR code base is not C++11 compli= ant. But in addition to using some C++03 idioms that are deprecated in C++1= 1, perhaps more importantly, the code is not taking advantage of new featur= es such as move semantics, constexpr, nothrow, and others. For the Imath cl= asses especially, using some of these may actually confer a performance ben= efit.<br><br>I feel kind of bad pointing this out while not really having t= he time at the moment to code up and submit an actual patch myself, but I t= hought I'd at least open the topic and see where the community stands o= n the issue of how and when to upgrade to C++11 and if it's important f= or modern OpenEXR to continue to support C++03. For point of reference, the= VFX Reference Platform [<a href=3D"http://www.vfxplatform.com/" target=3D"= _blank">http://www.vfxplatform.com/</a>] dictated C++11 for 2016 and 2017, = and will be C++14 for 2018.<br><br><span class=3D"m_6361944120489933342m_-2= 93618947442915972m_-6079636075028917681m_6758675243403444048Apple-tab-span"= style=3D"white-space:pre-wrap"> </span>-- lg<br><br>--<br>Larry Gritz<br><= a href=3D"mailto:[email protected]" target=3D"_blank">[email protected]</a>= <br><br><br><br><br><br>_______________________________________________<br>= Openexr-devel mailing list<br><a href=3D"mailto:[email protected]" t= arget=3D"_blank">[email protected]</a><br><a href=3D"https://lists.n= ongnu.org/mailman/listinfo/openexr-devel" target=3D"_blank">https://lists.n= ongnu.org/mailman/listinfo/openexr-devel</a><br></blockquote><br>-- <br>___= ________________________________________________________________________<br= >Dr. Werner Benger =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Visualization Research<br>Center for Co= mputation & Technology at Louisiana State University (CCT/LSU)<br>2019 = =C2=A0Digital Media Center, Baton Rouge, Louisiana 70803<br>Tel.: <a href= =3D"tel:(225)%20578-4809" value=3D"+12255784809" target=3D"_blank">+1 225 5= 78 4809</a> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= Fax.: <a href=3D"tel:(225)%20578-5362" value=3D"+12255785362" target=3D"_bl= ank">+1 225 578-5362</a><br><br><br>_______________________________________= ________<br>Openexr-devel mailing list<br><a href=3D"mailto:Openexr-devel@n= ongnu.org" target=3D"_blank">[email protected]</a><br><a href=3D"htt= ps://lists.nongnu.org/mailman/listinfo/openexr-devel" target=3D"_blank">htt= ps://lists.nongnu.org/mailman/listinfo/openexr-devel</a><br></div></div></b= lockquote></div><br></div></div><div> <div style=3D"word-wrap:break-word"><div style=3D"font-family:Helvetica;fon= t-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;l= etter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;w= hite-space:normal;word-spacing:0px">--</div><div style=3D"font-family:Helve= tica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:= normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transfor= m:none;white-space:normal;word-spacing:0px">Larry Gritz</div><div style=3D"= font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:no= rmal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:= 0px;text-transform:none;white-space:normal;word-spacing:0px"><a href=3D"mai= lto:[email protected]" target=3D"_blank">[email protected]</a></div><div st= yle=3D"font-family:Helvetica;font-size:14px;font-style:normal;font-variant-= caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-= indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br></d= iv><br class=3D"m_6361944120489933342m_-293618947442915972m_-60796360750289= 17681m_6758675243403444048Apple-interchange-newline"></div><br class=3D"m_6= 361944120489933342m_-293618947442915972m_-6079636075028917681m_675867524340= 3444048Apple-interchange-newline"> </div> <br></div></div><br>_______________________________________________<br> Openexr-devel mailing list<br> <a href=3D"mailto:[email protected]" target=3D"_blank">Openexr-devel= @nongnu.org</a><br> <a href=3D"https://lists.nongnu.org/mailman/listinfo/openexr-devel" rel=3D"= noreferrer" target=3D"_blank">https://lists.nongnu.org/mailman/listinfo/ope= nexr-devel</a><br> <br></blockquote></div><br></div> </div></blockquote></div><br></div></div></div><div style=3D"word-wrap:brea= k-word"><div><div><div> <div style=3D"word-wrap:break-word"><div style=3D"color:rgb(0,0,0);font-fam= ily:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;fon= t-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text= -transform:none;white-space:normal;word-spacing:0px">--</div><div style=3D"= color:rgb(0,0,0);font-family:Helvetica;font-size:14px;font-style:normal;fon= t-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:s= tart;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0p= x">Larry Gritz</div><div style=3D"color:rgb(0,0,0);font-family:Helvetica;fo= nt-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;= letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;= white-space:normal;word-spacing:0px"><a href=3D"mailto:[email protected]" t= arget=3D"_blank">[email protected]</a></div><div style=3D"color:rgb(0,0,0);= font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:no= rmal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:= 0px;text-transform:none;white-space:normal;word-spacing:0px"><br></div><br = class=3D"m_6361944120489933342m_-293618947442915972m_-6079636075028917681Ap= ple-interchange-newline"></div><br class=3D"m_6361944120489933342m_-2936189= 47442915972m_-6079636075028917681Apple-interchange-newline"> </div> <br></div></div></div></blockquote></div></div> _______________________________________________<br> Openexr-devel mailing list<br> <a href=3D"mailto:[email protected]" target=3D"_blank">Openexr-devel= @nongnu.org</a><br> <a href=3D"https://lists.nongnu.org/mailman/listinfo/openexr-devel" rel=3D"= noreferrer" target=3D"_blank">https://lists.nongnu.org/mailman/listinfo/ope= nexr-devel</a><br> </blockquote></div></div></div> --f403045eb0823a2cdc055682913c-- --===============3734369925726064652== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openexr-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/openexr-devel --===============3734369925726064652==--