Re: Request for feedback: OpenEXR v2.2.1 .so version changes
Richard Addison-Wood <[email protected]> Fri, 22 Dec 2017 14:30:30 +1300
| Newsgroups | gmane.comp.video.openexr.devel |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --===============7203333343977398744== Content-Type: multipart/alternative; boundary="------------3266E2C36936B12C02817160" Content-Language: en-US This is a multi-part message in MIME format. --------------3266E2C36936B12C02817160 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Basically, a 2.2.2 release would be in the correct form without the the questions about whether it is the correct variation. Anyone looking to grab the latest 2.2.* would get the security fix as a drop-in replacement for 2.2.0. A new 2.2.1 release would be in the correct form, but there is the possibility that the wrong variation as escaped during the window between the first release and the correction. Issue #250 certainly shows that the original 2.2.1 has been picked up. We would want to deprecate the 2.2.1 releases because of the ambiguity. But, the new official corrected 2.2.1 would still be valid. I am curious about the reasons why it might be preferable to only doing option a. As a reminder, we really do want to keep the bumps in version info in the namespace and the SONAME synchronized. On 12/22/17 12:29, Francois Chardavoine wrote: > Why do b) as well if we go with a) ? > > > On Thu, Dec 21, 2017 at 1:52 PM, Richard Addison-Wood > <[email protected] <mailto:[email protected]>> wrote: > > How about both options a and b? > > > On 12/22/17 05:56, Wayne Wooten wrote: >> >> The Pixar team would prefer option A as well. >> —Wayne >> >> On December 21, 2017 at 8:48:15 AM, Larry Gritz >> ([email protected] <mailto:[email protected]>) wrote: >> >>> I don't have a strong opinion, but the widely used convention is >>> that you should bump the so version when link compatibility >>> changes. I'm ok with (a), I don't think I've yet seen 2.2.1 in >>> the wild. >>> >>> >>>> On Dec 20, 2017, at 11:31 PM, Francois Chardavoine >>>> <[email protected] <mailto:[email protected]>> wrote: >>>> >>>> It has been brought to our attention that the decision to >>>> increment the so version as part of the 2.2.1 release may be >>>> problematic: >>>> https://github.com/openexr/openexr/issues/250 >>>> <https://github.com/openexr/openexr/issues/250> >>>> >>>> It would be great to get any additional community commentary on >>>> this. The .so version was bumped up mainly as an (admittedly >>>> conservative) precautionary measure, since it had been a long >>>> time since the previous release. Given that these are security >>>> vulnerability fixes, it's understandable that there might be in >>>> some cases a desire to be able to drop in replacement builds of >>>> OpenEXR without recompiling the host application. >>>> >>>> Two options we can take are: >>>> >>>> * a)- patch the currently tagged 2.2.1 to no longer include >>>> an .so version change. This could be controversial unless >>>> we get feedback that no one has adopted 2.2.1 in any >>>> significant way yet (to avoid confusion around "what >>>> version of 2.2.1 did you use?") >>>> * b)- release a 2.2.2 version which is identical to 2.2.1, >>>> except with the older so version. This is somewhat >>>> inelegant, but likely cleaner than option a). >>>> >>>> >>>> Does the community have any strong positions on this either way? >>>> Francois. >>> >>> -- >>> Larry Gritz >>> [email protected] <mailto:[email protected]> >>> >>> >>> >>> >>> _______________________________________________ >>> Openexr-devel mailing list >>> [email protected] <mailto:[email protected]> >>> https://lists.nongnu.org/mailman/listinfo/openexr-devel >>> <https://lists.nongnu.org/mailman/listinfo/openexr-devel> >> >> >> _______________________________________________ >> Openexr-devel mailing list >> [email protected] <mailto:[email protected]> >> https://lists.nongnu.org/mailman/listinfo/openexr-devel >> <https://lists.nongnu.org/mailman/listinfo/openexr-devel> > > > _______________________________________________ > Openexr-devel mailing list > [email protected] <mailto:[email protected]> > https://lists.nongnu.org/mailman/listinfo/openexr-devel > <https://lists.nongnu.org/mailman/listinfo/openexr-devel> > > --------------3266E2C36936B12C02817160 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> Basically, a 2.2.2 release would be in the correct form without the the questions about whether it is the correct variation. Anyone looking to grab the latest 2.2.* would get the security fix as a drop-in replacement for 2.2.0.<br> <br> A new 2.2.1 release would be in the correct form, but there is the possibility that the wrong variation as escaped during the window between the first release and the correction. Issue #250 certainly shows that the original 2.2.1 has been picked up.<br> <br> We would want to deprecate the 2.2.1 releases because of the ambiguity. But, the new official corrected 2.2.1 would still be valid.<br> <br> I am curious about the reasons why it might be preferable to only doing option a.<br> <br> As a reminder, we really do want to keep the bumps in version info in the namespace and the SONAME synchronized.<br> <br> <div class="moz-cite-prefix">On 12/22/17 12:29, Francois Chardavoine wrote:<br> </div> <blockquote type="cite" cite="mid:CADBZUEgUf6m5JJT2Yhp5eUd6QGDW0K8NOe60e3aGidP-7EnyBg@mail.gmail.com"> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <div dir="ltr">Why do b) as well if we go with a) ? <div><br> <div class="gmail_extra"><br> <div class="gmail_quote">On Thu, Dec 21, 2017 at 1:52 PM, Richard Addison-Wood <span dir="ltr"><<a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div text="#000000" bgcolor="#FFFFFF"> How about both options a and b? <div> <div class="h5"><br> <br> <div class="m_-3727155238712743362moz-cite-prefix">On 12/22/17 05:56, Wayne Wooten wrote:<br> </div> <blockquote type="cite"> <div id="m_-3727155238712743362bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto"><br> </div> <div> The Pixar team would prefer option A as well.</div> <div> </div> <div> —Wayne<br> <br> <p class="m_-3727155238712743362airmail_on">On December 21, 2017 at 8:48:15 AM, Larry Gritz (<a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a>) wrote:</p> <blockquote type="cite" class="m_-3727155238712743362clean_bq"><span> <div style="word-wrap:break-word"> <div> I don't have a strong opinion, but the widely used convention is that you should bump the so version when link compatibility changes. I'm ok with (a), I don't think I've yet seen 2.2.1 in the wild. <div><br> <div><br> <div> <blockquote type="cite"> <div>On Dec 20, 2017, at 11:31 PM, Francois Chardavoine <<a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a>> wrote:</div> <br class="m_-3727155238712743362Apple-interchange-newline"> <div> <div dir="ltr"> <div>It has been brought to our attention that the decision to increment the so version as part of the 2.2.1 release may be problematic:</div> <div><a href="https://github.com/openexr/openexr/issues/250" target="_blank" moz-do-not-send="true">https://github.com/openexr/<wbr>openexr/issues/250</a><br> </div> <div><br> </div> It would be great to get any additional community commentary on this. The .so version was bumped up mainly as an (admittedly conservative) precautionary measure, since it had been a long time since the previous release. Given that these are security vulnerability fixes, it's understandable that there might be in some cases a desire to be able to drop in replacement builds of OpenEXR without recompiling the host application. <div><br> </div> <div>Two options we can take are:</div> <div> <ul> <li>a)- patch the currently tagged 2.2.1 to no longer include an .so version change. This could be controversial unless we get feedback that no one has adopted 2.2.1 in any significant way yet (to avoid confusion around "what version of 2.2.1 did you use?")<br> </li> <li>b)- release a 2.2.2 version which is identical to 2.2.1, except with the older so version. This is somewhat inelegant, but likely cleaner than option a).<br> </li> </ul> </div> <div><br> </div> <div>Does the community have any strong positions on this either way?</div> <div>Francois.</div> </div> </div> </blockquote> </div> <br> <div> <div style="word-wrap:break-word"> <div style="color:rgb(0,0,0);font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">--</div> <div style="color:rgb(0,0,0);font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Larry Gritz</div> <div style="color:rgb(0,0,0);font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a></div> <div style="color:rgb(0,0,0);font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br> </div> <br class="m_-3727155238712743362Apple-interchange-newline"> </div> <br class="m_-3727155238712743362Apple-interchange-newline"> </div> <br> </div> </div> ______________________________<wbr>_________________ <br> Openexr-devel mailing list <br> <a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a> <br> <a href="https://lists.nongnu.org/mailman/listinfo/openexr-devel" target="_blank" moz-do-not-send="true">https://lists.nongnu.org/<wbr>mailman/listinfo/openexr-devel</a> <br> </div> </div> </span></blockquote> </div> <br> <fieldset class="m_-3727155238712743362mimeAttachmentHeader"></fieldset> <br> <pre>______________________________<wbr>_________________ Openexr-devel mailing list <a class="m_-3727155238712743362moz-txt-link-abbreviated" href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a> <a class="m_-3727155238712743362moz-txt-link-freetext" href="https://lists.nongnu.org/mailman/listinfo/openexr-devel" target="_blank" moz-do-not-send="true">https://lists.nongnu.org/<wbr>mailman/listinfo/openexr-devel</a> </pre> </blockquote> <br> </div> </div> </div> <br> ______________________________<wbr>_________________<br> Openexr-devel mailing list<br> <a href="mailto:[email protected]" moz-do-not-send="true">[email protected]</a><br> <a href="https://lists.nongnu.org/mailman/listinfo/openexr-devel" rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.nongnu.org/<wbr>mailman/listinfo/openexr-devel</a><br> <br> </blockquote> </div> <br> </div> </div> </div> </blockquote> <br> </body> </html> --------------3266E2C36936B12C02817160-- --===============7203333343977398744== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openexr-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/openexr-devel --===============7203333343977398744==--