Re: CMAKE_CXX_STANDARD

Nick Porcino <[email protected]> Fri, 13 Jul 2018 22:50:59 +0000
Newsgroups gmane.comp.video.openexr.devel
Message-ID <CY4PR16MB1670A5A0FD358B7A478CFC92A4580@CY4PR16MB1670.namprd16.prod.outlook.com>
--===============3065161328986224498==
Content-Language: en-US
Content-Type: multipart/alternative;
	boundary="_000_CY4PR16MB1670A5A0FD358B7A478CFC92A4580CY4PR16MB1670namp_"

--_000_CY4PR16MB1670A5A0FD358B7A478CFC92A4580CY4PR16MB1670namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

The develop branch of OpenEXR uses CMake 3 features. So that line is an err=
or.

I hadn't thought about it, but it's troubling* to think that we might have =
to preserve compatibility with CMake 2.x

* troubling =3D=3D sobbing in terror in the corner as the shambling revenan=
t shadow of CMake 2 groans and lurches forward belching broken features and=
 ad hoc syntax


________________________________
From: Openexr-devel <[email protected]=
> on behalf of Larry Gritz <[email protected]>
Sent: Friday, July 13, 2018 11:47 AM
To: [email protected]
Subject: [Openexr-devel] CMAKE_CXX_STANDARD

Is anybody troubled by the fact that the OpenEXR CMakeLists.txt starts with

CMAKE_MINIMUM_REQUIRED(VERSION 2.8)

but then makes use of CMAKE_CXX_STANDARD, which was only introduced with CM=
ake 3.1?

So I think that if anybody actually uses CMake < 3.1, it will just silently=
 fail to provide the right -std=3Dc++XX flags.


--
Larry Gritz
[email protected]





_______________________________________________
Openexr-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/openexr-devel

--_000_CY4PR16MB1670A5A0FD358B7A478CFC92A4580CY4PR16MB1670namp_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo=
ttom:0;} </style>
</head>
<body dir=3D"ltr">
<div style=3D"font-family: Calibri, Helvetica, sans-serif; font-size: 12pt;=
 color: rgb(0, 0, 0);">
The develop branch of OpenEXR uses CMake 3 features. So that line is an err=
or.</div>
<div style=3D"font-family: Calibri, Helvetica, sans-serif; font-size: 12pt;=
 color: rgb(0, 0, 0);">
<br>
</div>
<div style=3D"font-family: Calibri, Helvetica, sans-serif; font-size: 12pt;=
 color: rgb(0, 0, 0);">
I hadn't thought about it, but it's troubling* to think that we might have =
to preserve compatibility with CMake 2.x</div>
<div style=3D"font-family: Calibri, Helvetica, sans-serif; font-size: 12pt;=
 color: rgb(0, 0, 0);">
<br>
</div>
<div style=3D""><font color=3D"#000000" face=3D"Calibri, Helvetica, sans-se=
rif">* troubling =3D=3D sobbing in terror in the corner as the shambling re=
venant&nbsp;shadow of CMake 2 groans and lurches forward belching broken fe=
atures and ad hoc syntax</font></div>
<div style=3D""><font color=3D"#000000" face=3D"Calibri, Helvetica, sans-se=
rif"><br>
</font></div>
<div style=3D""><font color=3D"#000000" face=3D"Calibri, Helvetica, sans-se=
rif"><br>
</font></div>
<hr style=3D"display:inline-block;width:98%" tabindex=3D"-1">
<div id=3D"divRplyFwdMsg" dir=3D"ltr"><font face=3D"Calibri, sans-serif" st=
yle=3D"font-size:11pt" color=3D"#000000"><b>From:</b> Openexr-devel &lt;ope=
nexr-devel-bounces&#43;[email protected]&gt; on behalf of La=
rry Gritz &lt;[email protected]&gt;<br>
<b>Sent:</b> Friday, July 13, 2018 11:47 AM<br>
<b>To:</b> [email protected]<br>
<b>Subject:</b> [Openexr-devel] CMAKE_CXX_STANDARD</font>
<div>&nbsp;</div>
</div>
<div class=3D"BodyFragment"><font size=3D"2"><span style=3D"font-size:11pt;=
">
<div class=3D"PlainText">Is anybody troubled by the fact that the OpenEXR C=
MakeLists.txt starts with<br>
<br>
CMAKE_MINIMUM_REQUIRED(VERSION 2.8)<br>
<br>
but then makes use of CMAKE_CXX_STANDARD, which was only introduced with CM=
ake 3.1?<br>
<br>
So I think that if anybody actually uses CMake &lt; 3.1, it will just silen=
tly fail to provide the right -std=3Dc&#43;&#43;XX flags.<br>
<br>
<br>
--<br>
Larry Gritz<br>
[email protected]<br>
<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
Openexr-devel mailing list<br>
[email protected]<br>
<a href=3D"https://lists.nongnu.org/mailman/listinfo/openexr-devel">https:/=
/lists.nongnu.org/mailman/listinfo/openexr-devel</a><br>
</div>
</span></font></div>
</body>
</html>

--_000_CY4PR16MB1670A5A0FD358B7A478CFC92A4580CY4PR16MB1670namp_--


--===============3065161328986224498==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Openexr-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/openexr-devel

--===============3065161328986224498==--