Re: [patch] asm-types confusion

[email protected] (Andrew Church)
Newsgroups gmane.comp.video.transcode.devel
Message-ID <[email protected]>
>Hello.
>
>When building transcode for Fedora devel I noticed that there is some
>confusion with asm-types in import/nuv/RTjpegN.h It seems it tries to
>define some types that really should come from asm/types.h and the
>include guard used is all wrong, especially on x86_64... The attached
>patch fixes the compilation issue and applies to the HEAD branch as
>well.
[...]
>+#include <asm/types.h>

Unfortunately, I doubt this will work very well on non-Linux platforms;
the proper solution(*) is to #include <stdint.h> and use uint8_t and
friends. Francesco, I have a vague recollection that you had a patch
along those lines in the works; is that the case?  If not, I'll see what
I can put together.

(*) The _proper_ solution would be to get rid of it entirely and link it
    in from an external library, but I seem to recall failing to find
    such a library last time I looked...

  --Andrew Church
    [email protected]
    http://achurch.org/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.