stabilization plugin patch

Georg Martius <[email protected]> Sat, 6 Dec 2008 23:56:37 +0100
Newsgroups gmane.comp.video.transcode.devel
Message-ID <[email protected]>
Hello everyone,

please find attached a patch for the stabilization plugin and the tclist for 
HEAD (created with cvs diff).
I corrected (hopefully) all remaining code-style issues and some minor problem 
but more importantly fixed a bug in the new tclist implementation. This 
caused the stabilization plugin to segfault - took me a while to nail down 
the problem.
If there is now anything which hinders the plugin from being included in the 
next release, please let me know. I was really a bit disappointed that it did 
not make in into the last 2 releases without obvious reasons. It is 
a) quite demotivating to wait so long before things get included
b) difficult to improve/debug the plugin if nobody can use it.
Anyway, sorry for the rant.

I saw in the tclist.c another thing I was wondering about. After a 
tc_alloc(...) or similar the pointer is checked for NULL and if so the 
function returns silently, e.g. in tclist.c:335: tc_list_insert_dup(...)
I would rather suggest to die or at least complain with an _error message_ 
because it actually a severe problem and should not be hidden.

Best regards,
	Georg

-- 
---- Georg Martius,  Tel: +49 177 6413311  -----
------- http://www.flexman.homeip.net ----------
stabilization0_43_and_tclist.patch.gz (application/x-gzip, 2.1 KB) - not displayed
signature.asc (application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBJOwMt7Y/IAAz6KBMRAqyqAJ9CTQtXWXH/gkpIrwsstOiILJhGSgCeO4Px
qmK/1ROmuHEcGf3nYqb4fAo=
=SCzF
-----END PGP SIGNATURE-----