Re: [PATCH] cleanup option handling export_mov

Carl Karsten <[email protected]> Mon, 15 Dec 2008 13:21:49 -0600

Newsgroups	gmane.comp.video.transcode.devel
Message-ID	<[email protected]>

Stefan Scheffler wrote:
> Hi,
> 
> this patch makes export_mov use optstr_get to parse meta data and
> extended/codecs options. The current parser is pretty ugly and doesn't
> handle non int values.
> 

When you gave me that patch, you also gave me:

"this makes -y raw work"

transcode/export/export_raw.c

-       srcfmt = IMG_YUV422P;
+       srcfmt = IMG_UYVY;

Should that get committed?

Carl K

export_raw.c.diff (text/x-patch, 611 B)

Index: export/export_raw.c
===================================================================
RCS file: /cvstc/transcode/export/export_raw.c,v
retrieving revision 1.43
diff -u -r1.43 export_raw.c
--- export/export_raw.c 12 Jul 2007 10:14:37 -0000      1.43
+++ export/export_raw.c 22 Nov 2008 03:13:15 -0000
@@ -224,7 +224,7 @@
          tc_log_info(MOD_NAME, "codec=%s, fps=%6.3f, width=%d, height=%d",
                  fcc, vob->ex_fps, vob->ex_v_width, vob->ex_v_height);
 
-       srcfmt = IMG_YUV422P;
+       srcfmt = IMG_UYVY;
        if (!vob->ex_v_fcc)
            destfmt = IMG_UYVY;
        break;