DestroyConstitute fix

David Liontooth <[email protected]> Sun, 28 Nov 2010 13:19:31 -0800
Newsgroups gmane.comp.video.transcode.user
Message-ID <[email protected]> 
This is a multi-part message in MIME format.
--------------080101010506000803060903
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


According to 
https://bugs.launchpad.net/ubuntu/+source/transcode/+bug/539106, the API 
of imagemagick has changed and DestroyConstitute() was replaced by 
ConstituteComponentTerminus(). This function is called in two places in 
transcode -- the logoaway filter and export_im. See also 
http://developer.berlios.de/bugs/?func=detailbug&bug_id=16844&group_id=10094

Could we fix this?

--- export_im.c 2009-02-21 13:01:57.000000000 -0800
+++ export_im.c.new     2010-11-28 12:41:49.000000000 -0800
@@ -220,7 +220,7 @@

    if(param->flag == TC_VIDEO) {
      DestroyImageInfo(image_info);
-    DestroyConstitute();
+    ConstituteComponentTerminus();
      DestroyMagick();

      free(tmp_buffer);

--- filter_logoaway.c   2009-03-28 01:39:08.000000000 -0700
+++ filter_logoaway.c.new       2010-11-28 12:53:35.000000000 -0800
@@ -865,7 +865,7 @@
      if (data[instance]->dumpimage != (Image *)NULL) {
        DestroyImage(data[instance]->dumpimage);
        DestroyImageInfo(data[instance]->dumpimage_info);
-      DestroyConstitute();
+      ConstituteComponentTerminus();
      }
      DestroyExceptionInfo(&data[instance]->exception_info);
      DestroyMagick();

BTW, since transcode 1.1 hangs on this command:

transcode -q 0 -o test -y im -F png -x mov,null -i file.mp4 -c 
0:00:00-0:00:00.1,0:00:10-0:00:10.1

I've started using ffmpeg, but it takes twice as long :-<

It would be great if we could keep transcode functional.

Cheers,
Dave


--------------080101010506000803060903
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
  </head>
  <body text="#000000" bgcolor="#ffffff">
    <br>
    According to
    <a class="moz-txt-link-freetext" href="https://bugs.launchpad.net/ubuntu/+source/transcode/+bug/539106">https://bugs.launchpad.net/ubuntu/+source/transcode/+bug/539106</a>, the
    API of imagemagick has changed and DestroyConstitute() was replaced
    by ConstituteCompo<wbr>nentTerminus(<wbr>). This function is called
    in two places in transcode -- the logoaway filter and export_im. See
    also
<a class="moz-txt-link-freetext" href="http://developer.berlios.de/bugs/?func=detailbug&amp;bug_id=16844&amp;group_id=10094">http://developer.berlios.de/bugs/?func=detailbug&amp;bug_id=16844&amp;group_id=10094</a><br>
    <br>
    Could we fix this?<br>
    <br>
    --- export_im.c 2009-02-21 13:01:57.000000000 -0800<br>
    +++ export_im.c.new&nbsp;&nbsp;&nbsp;&nbsp; 2010-11-28 12:41:49.000000000 -0800<br>
    @@ -220,7 +220,7 @@<br>
    &nbsp;<br>
    &nbsp;&nbsp; if(param-&gt;flag == TC_VIDEO) {<br>
    &nbsp;&nbsp;&nbsp;&nbsp; DestroyImageInfo(image_info);<br>
    -&nbsp;&nbsp;&nbsp; DestroyConstitute();<br>
    +&nbsp;&nbsp;&nbsp; ConstituteComponentTerminus();<br>
    &nbsp;&nbsp;&nbsp;&nbsp; DestroyMagick();<br>
    &nbsp;<br>
    &nbsp;&nbsp;&nbsp;&nbsp; free(tmp_buffer);<br>
    <br>
    --- filter_logoaway.c&nbsp;&nbsp; 2009-03-28 01:39:08.000000000 -0700<br>
    +++ filter_logoaway.c.new&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 2010-11-28 12:53:35.000000000 -0800<br>
    @@ -865,7 +865,7 @@<br>
    &nbsp;&nbsp;&nbsp;&nbsp; if (data[instance]-&gt;dumpimage != (Image *)NULL) {<br>
    &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; DestroyImage(data[instance]-&gt;dumpimage);<br>
    &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; DestroyImageInfo(data[instance]-&gt;dumpimage_info);<br>
    -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; DestroyConstitute();<br>
    +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ConstituteComponentTerminus();<br>
    &nbsp;&nbsp;&nbsp;&nbsp; }<br>
    &nbsp;&nbsp;&nbsp;&nbsp; DestroyExceptionInfo(&amp;data[instance]-&gt;exception_info);<br>
    &nbsp;&nbsp;&nbsp;&nbsp; DestroyMagick();<br>
    <br>
    BTW, since transcode 1.1 hangs on this command:<br>
    <br>
    transcode -q 0 -o test -y im -F png -x mov,null -i file.mp4 -c
    0:00:00-0:00:00.1,0:00:10-0:00:10.1<br>
    <br>
    I've started using ffmpeg, but it takes twice as long :-&lt;&nbsp;&nbsp; <br>
    <br>
    It would be great if we could keep transcode functional.<br>
    <br>
    Cheers,<br>
    Dave<br>
    <br>
  </body>
</html>

--------------080101010506000803060903--