Re: [PATCH] SEGV fixed in dvbpsi_decoder_psi_section_add
Roberto Corno <[email protected]>
| Newsgroups | gmane.comp.video.videolan.libdvbpsi.devel |
|---|---|
| Message-ID | <CAO6YRm-bbD0oN3iZa_O+tARBiP2=1HEZ7R77wvZvoaPh4suo5Q@mail.gmail.com> |
Hi Jean-Paul,
it seems that your patch is the right one. I tested it and it seems to
correctly fix the problem.
Regards
Roberto
On 4 September 2012 13:34, Jean-Paul Saman <[email protected]> wrote:
> Robert,
>
> On Mon, Sep 3, 2012 at 3:07 PM, Roberto Corno <[email protected]>
> wrote:
> > SEGV happens within dvbpsi_decoder_psi_section_add when p->i_number ==
> > p_section->i_number and p_prev == NULL.
> > It's the first branch of the while(p) loop.
> > I got it with a heavily degraded transport stream, where a lot of CC
> error
> > occur.
> > I've added the check for p_prev==NULL
> > Patch attached.
>
> Your patch ignores the new section instead of replacing the section
> with the same number.
> The caller could therefor leak the section pointer. Please try this
> patch instead.
>
> Kind regards,
>
> Jean-Paul Saman
>
_______________________________________________
libdvbpsi-devel mailing list
[email protected]
http://mailman.videolan.org/listinfo/libdvbpsi-devel