Re: libdvpsi-1.0.0 on NetBSD

Hi Thomas,

On Wed, Jan 23, 2013 at 1:49 PM, Thomas Klausner <[email protected]> wrote:

> Hi Jean-Paul!
>
> Thanks for your reply. I'm a bit confused what kind of patch you expect.
>
> I can't provide a patch for the SOL_IP* stuff since I don't know what
> the code is supposed to do if the operating system has no SOL_IP*
> support.
>

Leave it as is for now.


> As for the second part, do you know why there was a try to disable the
> netinet/ip.h inclusion on *BSD? I would just remove the #ifdef. I can
> provide a patch for that if you want.
>

If that headerfile is supported on *BSD, then it should be allowed and the
ifdef can be removed.
Please sent a git formatted patch (or a diff -u).

Kind regards,
Jean-Paul Saman


>  Thomas
>
> On Wed, Jan 23, 2013 at 01:42:36PM +0100, Jean-Paul Saman wrote:
> > Hi Thomas,
> >
> > Could you provide a patch for this? I do not have a *BSD system to test
> > against
> >
> > Kind regards,
> >
> > Jean-Paul Saman.
> >
> >
> > On Mon, Jan 21, 2013 at 3:58 PM, Thomas Klausner <[email protected]> wrote:
> >
> > > Hi!
> > >
> > > I've recently updated the pkgsrc package for libdvbpsi to 1.0.0.
> > >
> > > For this to build, I had to disable the examples directory, in
> > > particular dvbinfo, because its udp.c file assumes that SOL_IP and
> > > SOL_IPV6 are defined in system headers; which they are not on NetBSD.
> > > I don't know what the code should do if they are not defined, so I
> > > couldn't adapt it.
> > >
> > > Please check for SOL_IP* in the configure script and adapt udp.c if
> > > they are missing.
> > >
> > > Another related issue: The code also checks for "#ifndef BSD" before
> > > including netinet/ip.h (in three files). I'm not sure what the point
> > > of this check is -- netinet/ip.h does exist on NetBSD -- but as it is,
> > > it won't work, since no BSD I know of defines a BSD symbol, nor does
> > > the configure script provide it (AFAICT).
> > >
> > > Cheers,
> > >  Thomas
> > > _______________________________________________
> > > libdvbpsi-devel mailing list
> > > [email protected]
> > > http://mailman.videolan.org/listinfo/libdvbpsi-devel
> > >
>

_______________________________________________
libdvbpsi-devel mailing list
[email protected]
http://mailman.videolan.org/listinfo/libdvbpsi-devel