Re: [PATCH] build failure on Debian kfreebsd

On Thu, Aug 22, 2013 at 7:09 PM, Sebastian Ramacher <[email protected]>wrote:

> On 2013-08-19 14:23:17, Jean-Paul Saman wrote:
> > On Mon, Aug 19, 2013 at 11:38 AM, Alessio Treglia <[email protected]
> >wrote:
> >
> > > Hi there,
> > >
> > > libdvbpsi failed to build on Debian kfreebsd in the past.
> > > Sebastian Ramacher worked on a patch to fix such issue, the description
> > > follows:
> > >    MSG_CMSG_CLOEXEC is a flag for recvmsg and not recv. Thus rewrite
> > >    {udp,tcp}_open to create sockets with SOCK_CLOEXEC. If SOCK_CLOEXEC
> is
> > > not
> > >    available, FD_CLOEXEC is set instead.
> > >
> > > You find the patch attached, thanks for considering.
> > > Cheers,
> > >
> >
> > Thanks for sending in this patch. I reviewed and modified the patch and
> > attached it here for double checking by you.
>
> With the new patch, #include <stdbool.h> is needed in both tcp.c and
> udp.c:
>

oops. thanks for testing.

Kind regards,

Jean-Paul Saman


> | tcp.c:62:1: error: unknown type name 'bool'
> |  static bool set_fdsocketclosexec(int s)
> |  ^
> | tcp.c: In function 'set_fdsocketclosexec':
> | tcp.c:69:20: error: 'true' undeclared (first use in this function)
> |              return true;
> |                     ^
> | tcp.c:69:20: note: each undeclared identifier is reported only once for
> each function it appears in
> | tcp.c:74:12: error: 'false' undeclared (first use in this function)
> |      return false;
> |             ^
> | tcp.c:75:1: error: control reaches end of non-void function
> [-Werror=return-type]
> |  }
> |  ^
> | cc1: all warnings being treated as errors
>
> (libdvbpsi 1.1.0 with the patch applied.)
>
> Regards
> --
> Sebastian Ramacher
>

_______________________________________________
libdvbpsi-devel mailing list
[email protected]
https://mailman.videolan.org/listinfo/libdvbpsi-devel