Re: Section CRC not being checked

Brad Bitterman <[email protected]> Wed, 2 Oct 2013 16:00:28 -0400

Newsgroups	gmane.comp.video.videolan.libdvbpsi.devel
Message-ID	<[email protected]>

I'll test them and let you know.

Thanks,

Brad Bitterman
[email protected]



On Oct 2, 2013, at 1:30 PM, Jean-Paul Saman <[email protected]> wrote:

> Brad,
> 
> On Wed, Oct 2, 2013 at 7:03 PM, Brad Bitterman <[email protected]> wrote:
> The patch works.
> 
> On another note, in atsc_mgt.c I think there might be an issue in dvbpsi_AddSectionMGT. At line 387 there is a check to see if p_decoder->p_building_mgt gets created from the call to dvbpsi_atsc_NewMGT. The check is as follows:
> 
> if (p_decoder->p_building_mgt)
>          return false;
> 
> Shouldn't it be this:
> 
> if (!p_decoder->p_building_mgt)
>           return false;
> 
>  
> indeed, I quickly checked 2 other ATSC table  and they have the same problem.
> I guess it refers to all ATSC tables. Could you prepare a patch for all ATSC tables and properly test it?
> 
> I do not have ATSC sources, so cannot test.
> 
> Kind regards,
> 
> Jean-Paul Saman.
>

_______________________________________________
libdvbpsi-devel mailing list
[email protected]
https://mailman.videolan.org/listinfo/libdvbpsi-devel

signature.asc (application/pgp-signature, 235 B)