tables/sis.c: Dereference null pointer (CID 17263)

[email protected] (Jean-Paul Saman) Wed, 16 Apr 2014 15:53:32 +0200 (CEST)
Newsgroups gmane.comp.video.videolan.libdvbpsi.devel
Message-ID <[email protected]>
libdvbpsi | branch: master | Jean-Paul Saman <[email protected]> | Fri Apr 11 15:47:38 2014 +0200| [0b1c6c6db288580c3fed2d3374cf731619a243d8] | committer: Jean-Paul Saman

tables/sis.c: Dereference null pointer (CID 17263)

The wrong pointer was checked for having a null value leading to the
null pointer dereference bug.

> http://git.videolan.org/gitweb.cgi/libdvbpsi.git/?a=commit;h=0b1c6c6db288580c3fed2d3374cf731619a243d8
---

 src/tables/sis.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tables/sis.c b/src/tables/sis.c
index 602bb7a..bbd82b8 100644
--- a/src/tables/sis.c
+++ b/src/tables/sis.c
@@ -114,7 +114,7 @@ void dvbpsi_sis_detach(dvbpsi_t *p_dvbpsi, uint8_t i_table_id, uint16_t i_extens
     i_extension = 0;
     dvbpsi_demux_subdec_t* p_subdec;
     p_subdec = dvbpsi_demuxGetSubDec(p_demux, i_table_id, i_extension);
-    if (p_demux == NULL)
+    if (p_subdec == NULL)
     {
         dvbpsi_error(p_dvbpsi, "SIS Decoder",
                          "No such SIS decoder (table_id == 0x%02x,"

_______________________________________________
libdvbpsi-devel mailing list
[email protected]
https://mailman.videolan.org/listinfo/libdvbpsi-devel