Re: [PATCH 1/2] Correctly flag mpeg2 video data in video_stream_descriptor

On 08/12/14 04:04, Jean-Baptiste Kempf wrote:
> See ISO/IEC 13818-1 : 2000, table 2-40 and 2.6.3
> 
> See https://trac.videolan.org/vlc/ticket/4200

Looks good

> ---
>  src/descriptors/dr_02.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/descriptors/dr_02.c b/src/descriptors/dr_02.c
> index 1c35d83..774a1c0 100644
> --- a/src/descriptors/dr_02.c
> +++ b/src/descriptors/dr_02.c
> @@ -60,7 +60,7 @@ dvbpsi_vstream_dr_t * dvbpsi_DecodeVStreamDr(dvbpsi_descriptor_t * p_descriptor)
>    if(!p_decoded) return NULL;
>  
>    /* Decode data and check the length */
> -  p_decoded->b_mpeg2 = (p_descriptor->p_data[0] & 0x04) ? true : false;
> +  p_decoded->b_mpeg2 = !((p_descriptor->p_data[0] & 0x04) ? true : false);

Rather use ? false : true;

>    if(    (!p_decoded->b_mpeg2 && (p_descriptor->i_length != 1))
>        || (p_decoded->b_mpeg2 && (p_descriptor->i_length != 3)))
>    {
> 
_______________________________________________
libdvbpsi-devel mailing list
[email protected]
https://mailman.videolan.org/listinfo/libdvbpsi-devel