Re: [PATCH] BUG - SCTE Descriptor 8A always fails to parse

--===============4314937545133480957==
Content-Type: multipart/alternative; boundary="94eb2c094f8e045f8505541a2a40"

--94eb2c094f8e045f8505541a2a40
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 12, 2017 at 12:50 AM, Steven Toth <[email protected]> wrote:

> Found a bug, libdvbpsi isn=E2=80=99t parsing SCTE descriptor 0x8a correct=
ly. The
> descriptor according to the formal specification (2004 through 2016) stat=
es
> that the payload is always one byte long. The parser rejects descriptors
> with a single byte of payload.
>
> http://www.scte.org/SCTEDocs/Standards/SCTE%2035%202016.pdf
>
> See page 19 section 8.2 for the correct descriptor specification (single
> byte).
>
> Patch attached.
>

Patch applied to master and branch/1.3.0-bugfix.

Thank you for contributing.

Kind regards,

Jean-Paul Saman


>
>
> =E2=80=94
> Steven Toth - LTN Global
> [email protected]
>
>
>
> _______________________________________________
> libdvbpsi-devel mailing list
> [email protected]
> https://mailman.videolan.org/listinfo/libdvbpsi-devel
>
>

--94eb2c094f8e045f8505541a2a40
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Wed, Jul 12, 2017 at 12:50 AM, Steven Toth <span dir=3D"ltr">&lt;<a =
href=3D"mailto:[email protected]" target=3D"_blank">[email protected]</=
a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0=
 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Found a bug, libdvbp=
si isn=E2=80=99t parsing SCTE descriptor 0x8a correctly. The descriptor acc=
ording to the formal specification (2004 through 2016) states that the payl=
oad is always one byte long. The parser rejects descriptors with a single b=
yte of payload.<br>
<br>
<a href=3D"http://www.scte.org/SCTEDocs/Standards/SCTE%2035%202016.pdf" rel=
=3D"noreferrer" target=3D"_blank">http://www.scte.org/SCTEDocs/<wbr>Standar=
ds/SCTE%2035%202016.pdf</a><br>
<br>
See page 19 section 8.2 for the correct descriptor specification (single by=
te).<br>
<br>
Patch attached.<br></blockquote><div><br></div><div>Patch applied to master=
 and branch/1.3.0-bugfix.<br><br></div><div>Thank you for contributing.<br>=
<br></div><div>Kind regards,<br></div><div><br>Jean-Paul Saman<br><br></div=
><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1=
px #ccc solid;padding-left:1ex">
<br>
<br><br>
=E2=80=94<br>
Steven Toth - LTN Global<br>
<a href=3D"mailto:[email protected]">[email protected]</a><br>
<br>
<br>
<br>______________________________<wbr>_________________<br>
libdvbpsi-devel mailing list<br>
<a href=3D"mailto:[email protected]">[email protected]=
g</a><br>
<a href=3D"https://mailman.videolan.org/listinfo/libdvbpsi-devel" rel=3D"no=
referrer" target=3D"_blank">https://mailman.videolan.org/<wbr>listinfo/libd=
vbpsi-devel</a><br>
<br></blockquote></div><br></div></div>

--94eb2c094f8e045f8505541a2a40--

--===============4314937545133480957==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGliZHZicHNp
LWRldmVsIG1haWxpbmcgbGlzdApsaWJkdmJwc2ktZGV2ZWxAdmlkZW9sYW4ub3JnCmh0dHBzOi8v
bWFpbG1hbi52aWRlb2xhbi5vcmcvbGlzdGluZm8vbGliZHZicHNpLWRldmVsCg==

--===============4314937545133480957==--