Re: [libdvdcss-devel] [PATCH 1/4] Replace DVD access method #defines by an enum.
Fabian Greffrath <[email protected]>
| Newsgroups | gmane.comp.video.videolan.libdvdcss,gmane.comp.video.videolan.libdvdcss.devel |
|---|---|
| Message-ID | <[email protected]> |
Am Montag, den 03.11.2014, 10:11 +0100 schrieb Diego Biurrun: > And what would I have gained apart from typing 3 characters less? > Suddenly I have to lookup the real type in another header instead of being > told that it is an enum. I see absolutely no gain from this procedure. > I'm not alone with my opinion; cf. the Linux style guide wrt typedeffing > struct names. I see it quite the other way round: As long as I know my variable is of type "dvdcss_method", I don't need to care if it is actually an enum or whatever. I got myself used to typedef enums as soon as I use them as actual variable types and not just for enumerating, I consider that "cleaner". But it was just a suggestion. - Fabian _______________________________________________ libdvdcss-devel mailing list [email protected] https://mailman.videolan.org/listinfo/libdvdcss-devel