Re: [libdvdcss-devel] [PATCH 04/12] dvd_region: Intentionally discard the return value from getchar()
Jean-Baptiste Kempf <[email protected]> Tue, 11 Nov 2014 14:38:09 +0100
| Newsgroups | gmane.comp.video.videolan.libdvdcss,gmane.comp.video.videolan.libdvdcss.devel |
|---|---|
| Message-ID | <[email protected]> |
Not really a fan of this.
It's a not really a useful fix.
On 11 Nov, Diego Biurrun wrote :
> This fixes CID 75512.
> ---
>
> Arguably a bogus fix, but whatever.
>
> test/dvd_region.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/dvd_region.c b/test/dvd_region.c
> index 52fcc9d..8747f19 100644
> --- a/test/dvd_region.c
> +++ b/test/dvd_region.c
> @@ -143,7 +143,7 @@ static int set_region(int fd, int region)
> }
> printf("Setting drive region can only be done a finite " \
> "number of times, press Ctrl-C now to cancel!\n");
> - getchar();
> + (void) getchar();
>
> region_mask = 0xff & ~(1 << (region - 1));
> printf("Setting region to %d( %x)\n", region, region_mask);
> --
> 2.1.0
>
> _______________________________________________
> libdvdcss-devel mailing list
> [email protected]
> https://mailman.videolan.org/listinfo/libdvdcss-devel
--
With my kindest regards,
--
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device
_______________________________________________
libdvdcss-devel mailing list
[email protected]
https://mailman.videolan.org/listinfo/libdvdcss-devel