Re: [libdvdcss-devel] [PATCH] Drop fallback definitions for POSIX integer types.

On 14 Nov, Diego Biurrun wrote :
> All relevant toolchains support POSIX integer types now.
> ---
>  src/common.h    | 15 ---------------
>  src/css.h       |  3 ++-
>  src/csstables.h |  2 +-
>  src/ioctl.h     |  2 +-
>  4 files changed, 4 insertions(+), 18 deletions(-)
> 
> diff --git a/src/common.h b/src/common.h
> index 259477b..71ef811 100644
> --- a/src/common.h
> +++ b/src/common.h
> @@ -26,21 +26,6 @@
>  #ifndef DVDCSS_COMMON_H
>  #define DVDCSS_COMMON_H
>  
> -/*****************************************************************************
> - * Basic types definitions
> - *****************************************************************************/
> -#if defined( HAVE_STDINT_H )
> -#   include <stdint.h>
> -#elif defined( HAVE_INTTYPES_H )
> -#   include <inttypes.h>
> -#else
> -    /* Fallback types (very x86-centric, sorry) */
> -    typedef unsigned char       uint8_t;
> -    typedef signed char         int8_t;
> -    typedef unsigned int        uint32_t;
> -    typedef signed int          int32_t;
> -#endif

OK.

> --- a/src/css.h
> +++ b/src/css.h
> @@ -29,7 +29,8 @@
>  #ifndef DVDCSS_CSS_H
>  #define DVDCSS_CSS_H
>  
> -#include "common.h"

Be careful, removing common.h is not OK everywhere, because it has
numerous work-arounds for broken systems, like Android or Windows or
OS/2


-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device
_______________________________________________
libdvdcss-devel mailing list
[email protected]
https://mailman.videolan.org/listinfo/libdvdcss-devel