Re: [libdvdcss-devel] [PATCH 1/7] Clean up and simplify raw device support.

On Sun, Nov 16, 2014 at 08:52:57PM +0100, Jean-Baptiste Kempf wrote:
> On 16 Nov, Diego Biurrun wrote :
> > On Sun, Nov 16, 2014 at 08:44:13PM +0100, Jean-Baptiste Kempf wrote:
> > > On 16 Nov, Diego Biurrun wrote :
> > > > Treat access to raw devices just like accessing any other device instead of
> > > > providing different semantics. libdvdcss now tries raw devices on all OSes
> > > > and bails out instead of continuing if accessing a raw device failed.
> > > 
> > > I'm not so sure about that, tbh.
> > > 
> > > Aren't you breaking some use cases?
> > 
> > Not sure which use cases you might mean.
> > 
> > Yes, this changes behavior, intentionally.  If raw device access is requested
> > and accessing the device fails, we bail out.  Previously libdvdcss would
> > continue.  However, I consider the new behavior more sensible.  If you want
> > raw access, silent fallback is no good IMO.
> 
> Why not fallback but with a warning?

That's what happened previously.  libdvdcss fails hard when failing to access
other devices, this makes it consistent.  It's also far simpler code.

Diego
_______________________________________________
libdvdcss-devel mailing list
[email protected]
https://mailman.videolan.org/listinfo/libdvdcss-devel