Re: [libdvdcss-devel] [PATCH] Do not include huge "windows.h" in main header, use with single typedef

Diego Biurrun <[email protected]> Tue, 18 Nov 2014 17:50:48 +0100

Newsgroups	gmane.comp.video.videolan.libdvdcss,gmane.comp.video.videolan.libdvdcss.devel
Message-ID	<20141118165048.GO7442@nibbler>

On Tue, Nov 18, 2014 at 06:46:43PM +0300, Evgeny Grin (Karlson2k) wrote:
> From: Evgeny Grin <[email protected]>
> 
> ---
>  src/libdvdcss.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Why?  I don't see why we should duplicate any Windows API internals.

> --- a/src/libdvdcss.h
> +++ b/src/libdvdcss.h
> @@ -27,8 +27,7 @@
>  #include <limits.h>
>  
>  #ifdef WIN32
> -#    include "config.h"
> -#    include <windows.h>
> +    typedef void* HANDLE; /* forward declaration */
>  #endif

The style is not OK; the file uses 4 spaces as indentation.

Diego
_______________________________________________
libdvdcss-devel mailing list
[email protected]
https://mailman.videolan.org/listinfo/libdvdcss-devel