Re: [libdvdcss-devel] win32: Use proper handle instead of file descriptor to access devices

Hi Jean-Baptiste!

On 2014-11-19 23:13 +0100, Jean-Baptiste Kempf wrote:
> On 19 Nov, Alexander Strasser wrote :
> >   It broke:
> >   - device.c:dvdcss_use_ioctls
> >   - integrity of the code base because it's incompatible with ioctl.c design
> >   - test/dvd_region.c (it uses internals and thus is not the same as below)
> >   - test/csstest and probably all other downstream clients
> 
> Can you detail the breakage?

  I could not test with a player yet. (Maybe tomorrow or at weekend.)

  Here are some outputs I get when running the programs under test:

csstest without 1b4e3f9
  $ DVDCSS_VERBOSE=2 test/csstest D: 1024
  libdvdcss debug: opening target `D:'
  libdvdcss debug: using Win2K API for access
  libdvdcss debug: disc reports copyright information 0x0
  libdvdcss debug: drive region(s) 2, region mask 0xfd, RPC-II, region
  code set
  libdvdcss debug: disc is unscrambled
[...]
  requested sector:
  000001ba...0d4e514811313801030202200100000000000d4e4149...
  sector is not scrambled

csstest with 1b4e3f9::
  $ DVDCSS_VERBOSE=2 test/csstest D: 1024
  libdvdcss debug: opening target `D:'
  libdvdcss debug: using Win2K API for access
[...]
  requested sector:
  000001ba...0d4e514811313801030202200100000000000d4e4149...
  sector is not scrambled


For dvd_region:
  $ DVDCSS_VERBOSE=2 test/dvd_region -d D:
  libdvdcss debug: opening target `D:'
  libdvdcss debug: using Win2K API for access
  libdvdcss debug: disc reports copyright information 0x0
  libdvdcss debug: drive region(s) 2, region mask 0xfd, RPC-II, region
  code set
  libdvdcss debug: disc is unscrambled
[...]
  ret 0, copyright 0
  Drive region info:
  Type: Drive region is set
  Region: 2 playable
  RPC Scheme: The Logical Unit _shall_ adhere to the specification and all
  requirements of the Content Scrambling System (CSS) license agreement
  concerning RPC.

vs:
  $ DVDCSS_VERBOSE=2 test/dvd_region -d D:
  libdvdcss debug: opening target `D:'
  libdvdcss debug: using Win2K API for access
[...]
  ret -1, copyright 0
  Drive region info:
  dvd_region: File exists


  Alexander

_______________________________________________
libdvdcss-devel mailing list
[email protected]
https://mailman.videolan.org/listinfo/libdvdcss-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlRtHHsACgkQp9ile6h25Y9WGACfazk74cUrClL/1nLXMuZtuRyR
ZckAn02YQcE2NWfexo65IwYryXeh5jTN
=24Cp
-----END PGP SIGNATURE-----