[PATCH] build: set dependency to libvlc_rtp for librtp_plugin

Dominique Leuenberger <[email protected]> Wed, 12 Jul 2023 15:40:29 +0200
Newsgroups gmane.comp.video.videolan.vlc.devel
Message-ID <[email protected]>
only libvlc_srtp_la was set as dependency, which results in build fails
like this:

[ 1066s]   CC       access/rtp/librtp_plugin_la-input.lo
[ 1066s]   CC       access/rtp/librtp_plugin_la-sdp.lo
[ 1066s]   CC       access/rtp/librtp_plugin_la-datagram.lo
[ 1066s]   CC       access/rtp/librtp_plugin_la-rtp.lo
[ 1066s]   CC       access/rtp/libvlc_srtp_la-srtp.lo
[ 1067s]   CCLD     libvlc_srtp.la
[ 1067s]   CCLD     librtp_plugin.la
[ 1067s] libtool:   error: cannot find the library 'libvlc_rtp.la' or
unhandled argument 'libvlc_rtp.la'
[ 1067s] make[4]: *** [Makefile:23838: librtp_plugin.la] Error 1

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel
0001-build-set-dependency-to-libvlc_rtp-for-librtp_plugin.patch (text/x-patch, 1.8 KB)
From e6126a0226307470ad11065a1dc0467271bb859e Mon Sep 17 00:00:00 2001
From: Dominique Leuenberger <[email protected]>
Date: Wed, 12 Jul 2023 15:34:20 +0200
Subject: [PATCH] build: set dependency to libvlc_rtp for librtp_plugin

only libvlc_srtp_la was set as dependency, which results in build fails
like this:

[ 1066s]   CC       access/rtp/librtp_plugin_la-input.lo
[ 1066s]   CC       access/rtp/librtp_plugin_la-sdp.lo
[ 1066s]   CC       access/rtp/librtp_plugin_la-datagram.lo
[ 1066s]   CC       access/rtp/librtp_plugin_la-rtp.lo
[ 1066s]   CC       access/rtp/libvlc_srtp_la-srtp.lo
[ 1067s]   CCLD     libvlc_srtp.la
[ 1067s]   CCLD     librtp_plugin.la
[ 1067s] libtool:   error: cannot find the library 'libvlc_rtp.la' or unhandled argument 'libvlc_rtp.la'
[ 1067s] make[4]: *** [Makefile:23838: librtp_plugin.la] Error 1
---
 modules/access/rtp/Makefile.am | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/modules/access/rtp/Makefile.am b/modules/access/rtp/Makefile.am
index 86c8e28b98..75461bff59 100644
--- a/modules/access/rtp/Makefile.am
+++ b/modules/access/rtp/Makefile.am
@@ -8,6 +8,7 @@ librtp_plugin_la_SOURCES = \
 librtp_plugin_la_CPPFLAGS = $(AM_CPPFLAGS) -I$(srcdir)/access/rtp
 librtp_plugin_la_CFLAGS = $(AM_CFLAGS)
 librtp_plugin_la_LIBADD = libvlc_rtp.la $(SOCKET_LIBS)
+librtp_plugin_la_DEPENDENCIES = libvlc_rtp.la
 
 # RTP library
 libvlc_rtp_la_SOURCES = access/rtp/rtpfmt.c access/rtp/rtp.h \
@@ -29,7 +30,7 @@ noinst_LTLIBRARIES += libvlc_srtp.la
 librtp_plugin_la_CPPFLAGS += -DHAVE_SRTP
 librtp_plugin_la_CFLAGS += $(GCRYPT_CFLAGS)
 librtp_plugin_la_LIBADD += libvlc_srtp.la $(GCRYPT_LIBS)
-librtp_plugin_la_DEPENDENCIES = libvlc_srtp.la
+librtp_plugin_la_DEPENDENCIES += libvlc_srtp.la
 endif
 
 noinst_HEADERS += access/rtp/fmtp.h
-- 
2.35.3