Re: Using VLC 4.0.0 on WSL2 Ubuntu 25.04 with wayland

 > Who said you shouldn't use the viewporter for the interface? You just 
can't instantiate it for the video surface.

Qt itself uses it for the interface surface since version 6.5. The video 
surface, when embedded, is expected to use the same scale the interface 
surface uses so that it fits perfectly. Thomas has previously provided a 
screenshot for this in 
https://code.videolan.org/videolan/vlc/-/merge_requests/5721#note_446336.

 > VLC doesn't support fractional video window dimensions anyway, 
because that would be totally overkill.

By fractional scale, I don't necessarily mean fractional size. There can 
be a big difference between, let's say, 1.0 and 1.5 scale, depending on 
the size.

One might say, why not report the size as `size * scale` instead of 
using viewporter. I did not want to couple size and scale, as that can 
be quite problematic, and that goes against the fractional scale 
protocol anyway. We should probably add a "scale" field to window 
structure, and introduce `vlc_window_ReportScale()` and not handle 
scaling in the interface.

 > That's a server/driver restriction, not a provider restriction.

I say that with proper justification, provider can impose additional 
restriction (only) when it is used. Imagine if there was no such 
`EGL_KHR_display_reference` at all, then we would not have EGL display 
just because some provider needs it?

 > And SHM is supposed to be the one module that works on *any* display 
server.

 > If embedding is not possible then you can't provide an embedded 
window. You don't get to provide a partially working partially crashing 
backend

Yes, we should fix this. However, we need to decide how.

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel