Re: [PATCH] clock: replace warning with explanatory comment in input_clock_SetJitter

--Apple-Mail=_A51CA867-A7DD-490B-BFA7-05DBD963220E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Hello Declan,

Thanks for your patch. We no longer accept contributions via the =
mailing-list. Please open a merge request on our gitlab.

Best regards,

Felix

> On 4. Jan 2026, at 18:12, Declan <[email protected]> wrote:
>=20
> Hi,
>=20
> This patch removes a compile-time #warning in input_clock_SetJitter() =
and
> replaces it with a descriptive comment explaining the known =
limitations of
> the current jitter handling logic.
>=20
> This avoids emitting a build warning while still documenting the =
incomplete
> state of the function for future improvements.
>=20
> No functional changes.
>=20
> Regards,
> Declan Rodrigues

--Apple-Mail=_A51CA867-A7DD-490B-BFA7-05DBD963220E
Content-Disposition: attachment;
	filename=0001-clock-replace-warning-with-explanatory-comment-in-in.patch
Content-Type: text/x-patch;
	x-unix-mode=0644;
	name="0001-clock-replace-warning-with-explanatory-comment-in-in.patch"
Content-Transfer-Encoding: quoted-printable

=46rom 1ce8b8e75b35cea9e51639bbd4430df7b6b45abe Mon Sep 17 00:00:00 2001
From: Declan1704 <[email protected]>
Date: Sun, 4 Jan 2026 22:26:35 +0530
Subject: [PATCH] clock: replace warning with explanatory comment in
 input_clock_SetJitter

---
 src/clock/input_clock.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/clock/input_clock.c b/src/clock/input_clock.c
index 01d873b679..44b106233d 100644
--- a/src/clock/input_clock.c
+++ b/src/clock/input_clock.c
@@ -460,7 +460,18 @@ void input_clock_ChangeSystemOrigin( input_clock_t =
*cl, vlc_tick_t i_system )
     UpdateListener( cl, false );
 }
=20
-#warning "input_clock_SetJitter needs more work"
+/* NOTE:
+ * input_clock_SetJitter() jitter handling is known to be incomplete.
+ *
+ * Known limitations:
+ *  - lateness history is lossy due to full buffer rebuild
+ *  - PTS delay only increases (never decreases)
+ *  - clock rate averaging uses a hardcoded minimum value
+ *
+ * This logic is kept for stability and backward compatibility.
+ * Any functional change should be done carefully and tested.
+ */
+
 void input_clock_SetJitter( input_clock_t *cl,
                             vlc_tick_t i_pts_delay, int i_cr_average )
 {
--=20
2.39.5


--Apple-Mail=_A51CA867-A7DD-490B-BFA7-05DBD963220E
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


--Apple-Mail=_A51CA867-A7DD-490B-BFA7-05DBD963220E
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel

--Apple-Mail=_A51CA867-A7DD-490B-BFA7-05DBD963220E--