[PATCH] input: log slave source creation failure

--===============6309557180976419516==
Content-Type: multipart/alternative; boundary="000000000000dcf6b1064fd8b147"

--000000000000dcf6b1064fd8b147
Content-Type: text/plain; charset="UTF-8"

Hi,

This patch adds a log message when InputSourceNew() fails in
input_SlaveSourceAdd().

It uses the existing SLAVE_ADD_CANFAIL flag to differentiate between
optional and required slave sources, logging warnings for optional failures
and errors for required ones. This makes such failures visible while
keeping the behavior unchanged.

Thanks,
Manjeet Yaduvanshi

From: Manjeet Yaduvanshi <[email protected]>
Subject: [PATCH] input: log slave source creation failure

diff --git a/src/input/input.c b/src/input/input.c
--- a/src/input/input.c
+++ b/src/input/input.c
@@
     input_source_t *p_source = InputSourceNew( psz_uri );
- if( !p_source )
- return VLC_EGENERIC;
+ if( !p_source )
+ {
+ if( b_can_fail )
+ msg_Warn( p_input, "could not create slave source for %s", psz_uri );
+ else
+ msg_Err( p_input, "could not create slave source for %s", psz_uri );
+
+ return VLC_EGENERIC;
+ }

--000000000000dcf6b1064fd8b147
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Hi,<br><br>This patch adds a log message when InputSource=
New() fails in input_SlaveSourceAdd().<br><br>It uses the existing SLAVE_AD=
D_CANFAIL flag to differentiate between optional and required slave sources=
, logging warnings for optional failures and errors for required ones. This=
 makes such failures visible while keeping the behavior unchanged.<br><br>T=
hanks,<br>Manjeet Yaduvanshi=C2=A0<br><div dir=3D"auto"><br></div><div dir=
=3D"auto">From: Manjeet Yaduvanshi &lt;<a href=3D"mailto:manjeetyaduvanshi2=
[email protected]" target=3D"_blank" rel=3D"noreferrer">manjeetyaduvanshi250@gma=
il.com</a>&gt;</div><div dir=3D"auto">Subject: [PATCH] input: log slave sou=
rce creation failure</div><div dir=3D"auto"><br></div><div dir=3D"auto">dif=
f --git a/src/input/input.c b/src/input/input.c</div><div dir=3D"auto">--- =
a/src/input/input.c</div><div dir=3D"auto">+++ b/src/input/input.c</div><di=
v dir=3D"auto">@@</div><div dir=3D"auto">=C2=A0 =C2=A0 =C2=A0input_source_t=
 *p_source =3D InputSourceNew( psz_uri );</div><div dir=3D"auto">-    if( !=
p_source )</div><div dir=3D"auto">-        return VLC_EGENERIC;</div><div d=
ir=3D"auto">+    if( !p_source )</div><div dir=3D"auto">+    {</div><div di=
r=3D"auto">+        if( b_can_fail )</div><div dir=3D"auto">+            ms=
g_Warn( p_input, &quot;could not create slave source for %s&quot;, psz_uri =
);</div><div dir=3D"auto">+        else</div><div dir=3D"auto">+           =
 msg_Err( p_input, &quot;could not create slave source for %s&quot;, psz_ur=
i );</div><div dir=3D"auto">+</div><div dir=3D"auto">+        return VLC_EG=
ENERIC;</div><div dir=3D"auto">+    }</div></div>

--000000000000dcf6b1064fd8b147--

--===============6309557180976419516==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel

--===============6309557180976419516==--