Re: [PATCH] input: log slave source creation failure

Hello,

Please open a merge request. Contributions by patch through the mailing-list are no longer accepted.

Note that we will not merge improvements of FIXME or TODO comments.

Best regards,

Felix

> On 20. Apr 2026, at 01:39, MANJEET YADUVANSHI <[email protected]> wrote:
> 
> Hi,
> 
> This patch adds a log message when InputSourceNew() fails in input_SlaveSourceAdd().
> 
> It uses the existing SLAVE_ADD_CANFAIL flag to differentiate between optional and required slave sources, logging warnings for optional failures and errors for required ones. This makes such failures visible while keeping the behavior unchanged.
> 
> Thanks,
> Manjeet Yaduvanshi 
> 
> From: Manjeet Yaduvanshi <[email protected]>
> Subject: [PATCH] input: log slave source creation failure
> 
> diff --git a/src/input/input.c b/src/input/input.c
> --- a/src/input/input.c
> +++ b/src/input/input.c
> @@
>      input_source_t *p_source = InputSourceNew( psz_uri );
> - if( !p_source )
> - return VLC_EGENERIC;
> + if( !p_source )
> + {
> + if( b_can_fail )
> + msg_Warn( p_input, "could not create slave source for %s", psz_uri );
> + else
> + msg_Err( p_input, "could not create slave source for %s", psz_uri );
> +
> + return VLC_EGENERIC;
> + }
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel