Re: [PATCH] sse2 version of greedy2frame deinterlacer

Am 10.06.2012 01:52, schrieb Darren Salt:
> I demand that Roland Scheidegger may or may not have written...
> 
>> here's the updated greedy2frame sse2 patch. In contrast to the first try
>> I've now made it fall back to the mmxext path when alignment
>> restrictions aren't met (I've also renamed that old path from sse as
>> it's really mmxext not sse). Thanks to Petri it also initializes the xmm
>> variables in a much less crappy way...
> [snip]
> 
> UTTERLY BROKEN PATCHES...
> 
> All is well on x86 and x86_64; that, in and of itself, is fine. BUT due to at
> least some of these MMX/SSE patches, building is now BROKEN on anything not
> x86-based. I don't know x86 asm or I might have given these more than a
> cursory glance...
> 
> Here I was, thinking that I could do a release in plenty of time for the
> Debian wheezy release freeze. Now, 1.2.2 *could* end up missing the freeze
> unless we get this mess fixed *quickly*.
> 
> I STRONGLY suggest that some reading of the build logs is in order. You will
> find the following link to be of use.
> 
> https://buildd.debian.org/status/logs.php?pkg=xine-lib-1.2&ver=1.2.2-1
> 

Sorry for that just some x86 specific code which was outside the X86 macros.
Looks like Petri already fixed it.
At some point I was actually wondering why the templates get included at
all, since that deinterlacer is x86 only anyway.

Roland

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/