Re: ff_audio_multichannel_support

Hello,

thanks for new patch.
there is any crash now for 5.1 to 2.0

I will do more test

See you


Le 21/05/2013 20:02, Torsten Jager a écrit :
> Hello,
>
>> i test your new patch and i found a bug:
>>
>> when movie is eac3 5.1 and switching to 2.0 for advertising ,xine crash.
>>
>> i upload a new sample for this bug.
>>
>>
>> http://dl.free.fr/rHbXvFhHa
>>
>> or here
>>
>> http://speedy.sh/5uWY8/expert.zip
>
> The second site worked fine with those terminals, thanks.
>
> Oh dear.
>
> I thought I could do this step by step but it seems not to work that
> way. So here is a shitload of changes:
>
> * Observe channel configuration immediately after av_decode_audio* ().
>    Do not try to access nonexistant channels after a 5.1 -> 2.0 switch
>    for example.
>
> * Add NULL plane pointer paranoia.
>
> * Assume generic channel layout when no detailled one provided.
>    Needed for wma2.
>
> * Follow user speaker arrangement changes on the fly.
>
> * Defer opening audio out until we have something to play.
>
> * Do not reopen audio out with identical settings. This and the
>    previous item should help avoiding waiting on some drivers.
>
> * Hard wire output to int16_t. Some of the code did assume that,
>    and we are converting to that anyway.
>
> * Do not read sample format from bits_per_coded_sample. Decoders
>    neither alter that field, nor do they force its value to their
>    output.
>
> * Rename some vars for better readability.
>
> [ff_audio_channel_mixer_5.diff]
> ff_audio_dec: fix multichannel playback
>
>
> Torsten
>
>
>


------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may