Re: xine-lib and libdvdnav

On su, 2015-05-31 at 18:27 +0000, Chris Rankin wrote:
> Hi,
> 
> 
> I've just been reminded that xine-lib contains its own private copy of
> libdvdav; this copy doesn't support the latest version of libdvdcss and
> so causes xine's DVD playback to fail with this error:
> libdvdread: Missing symbols in libdvdcss.so.2, this shouldn't happen ! 

https://bugs.xine-project.org/show_bug.cgi?id=558

They changed libdvdcss ABI without changing .so version. This triggers
old bug in internal libdvdnav. It would be easy to fix in xine-lib tree,
but fixing outdated internal copy is just waste of time ...

> The easiest solution is to compile xine-lib "--with-external-dvdnav", of 
> course. But it made me wonder - why does xine-lib contain its own copy of 
> libdvdnav in the first place? Has this libdvdnav been modified for some 
> reason? And if so, why weren't these changes pushed upstream?

I think libdvdnav was not maintained years ago and it was easier to use
& fix internal version. But, this changed some time ago, libdvdnav is
now maintained by VideoLAN. Most of the old fixes from various projects
should be already merged upstream.

> The internal dvdnav can only use libdvdcss <= 1.2.13, and also seems to
> contain a "crash" bug when the dvdnav plugin is closed that is caused 
> by freeing an invalid pointer. (This crash also happens when I use 
> libdvdcss 1.2.13 with Fedora 21/22's external libdvdnav, but vanishes
> when I upgrade to libdvdcss 1.3).
> 
> Any thoughts, anyone? My opinion is that we delete the internal 
> libdvdnav and require it as an external dependency instead.

+1

This is probably problem only for those compiling their own versions of
xine-lib. If -dev package is missing, outdated internal version is used.
I think (all?) distros already use external dvdnav when building
packages ?

> 
> Cheers,
> Chris
> 
> ------------------------------------------------------------------------------
> _______________________________________________
> xine-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xine-devel



------------------------------------------------------------------------------