Re: [PATCH] Use a better filename when creating a snapshot

On 12/02/2017 23:37, Mikko Rasa wrote:
> On 13.02.2017 00:17, Xavier Bachelot wrote:
>> As it seems neither Petri nor Torsten, the 2 active developers, have
>> enough privileges to make a full release with a proper tarball uploaded
>> to the website, I'm leaning toward using snapshots for Fedora. However,
>> the generated tarball name is not unique enough for my use, so I came up
>> with the attached patch, which will generate a tarball named
>> xine-lib-"version"-"date_of_changeset"hg"changeset_number".tar.xz
>> rather than
>> xine-lib-"version"hg.tar.gz
>>
>> Please review.
> 
> I don't know if the date part is necessary.  With git it could help in 
> maintaining ordering of version numbers, but mercurial already numbers 
> changesets in increasing order.
>
No strong opinion on the date part. Admittedly, it makes the version
longer, but make it more obvious when the snapshot was generated.
Here's what Fedora's packaging guidelines say about naming a snapshot :
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshot_packages
I took that as a reference, but I don't really care as long as a tarball
generated from a given commit has an unique name.

> Furthermore using dash as a separator in upstream version can be 
> problematic since some distributions use it for their own purposes, such 
> as tracking changes to packaging.  Therefore I would suggest:
> 
> xine-lib-<version>+hg<changeset#>.tar.whatever
> 
> This matches what Debian expects package versions to be.  I'm less 
> familiar with other distributions.
> 
There's no direct relation on the name of the tarball and the name,
version and release the distro maintainer will use for the resulting
package, so no strong opinion on this either.
Again, I only care about uniqueness of the tarball name, I'll adapt to
whatever xine-lib developers think is ok.
And note there's already a dash in the package name ;-)

> Also, if it seems that the original owners have abandoned the project 
> and are unreachable for purposes of handing over the repository and 
> website, perhaps it would be time to fork the project.
> 
Iirc, Petri said he'll try to reach out to former maintainers, I don't
know if he succeed or not. Let's wait for Petri an Torsten to make the
call. It would be a lot of work to rebuild everything mostly from the
ground.

Regards,
Xavier

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot