Re: xine-ui build error in lirc code

This is a multi-part message in MIME format.
--------------DB77236A775E1E620077DA86
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Le 24/07/2019 à 15:53, Xavier Bachelot a écrit :
> Hi,
> 
> While giving a try at latest xine-ui, I encountered a build failure in the lirc part of the code.
> Just reporting for now, I haven't taken the time to look at it.
> Here's the relevant extract of the log:
> 
>    CC       lirc.o
> BUILDSTDERR: lirc.c: In function 'xine_lirc_loop':
> BUILDSTDERR: lirc.c:119:10: error: too few arguments to function 'panel_is_visible'
> BUILDSTDERR:   119 |       if(panel_is_visible()) {
> BUILDSTDERR:       |          ^~~~~~~~~~~~~~~~
> BUILDSTDERR: In file included from common.h:59,
> BUILDSTDERR:                  from lirc.c:34:
> BUILDSTDERR: panel.h:43:5: note: declared here
> BUILDSTDERR:    43 | int panel_is_visible (xui_panel_t *panel);
> BUILDSTDERR:       |     ^~~~~~~~~~~~~~~~
> BUILDSTDERR: lirc.c:121:9: error: too few arguments to function 'panel_paint'
> BUILDSTDERR:   121 |         panel_paint();
> BUILDSTDERR:       |         ^~~~~~~~~~~
> BUILDSTDERR: In file included from common.h:59,
> BUILDSTDERR:                  from lirc.c:34:
> BUILDSTDERR: panel.h:42:6: note: declared here
> BUILDSTDERR:    42 | void panel_paint (xui_panel_t *panel);
> BUILDSTDERR:       |      ^~~~~~~~~~~
> BUILDSTDERR: make[4]: *** [Makefile:715: lirc.o] Error 1
> 

And now the patch.

Regards,
Xavier

--------------DB77236A775E1E620077DA86
Content-Type: text/x-patch;
 name="xine-ui-fix_lirc_build.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="xine-ui-fix_lirc_build.patch"

# HG changeset patch
# User Xavier Bachelot <[email protected]>
# Date 1563981998 -7200
#      Wed Jul 24 17:26:38 2019 +0200
# Node ID 69dbfc52b43b14ef441d2e0f40693bc6d6cd65ad
# Parent  8bb1b4727d824465fe34a8f50f3b191bb0184a27
Fix lirc build

diff -r 8bb1b4727d82 -r 69dbfc52b43b src/xitk/lirc.c
--- a/src/xitk/lirc.c	Tue Jul 23 17:51:48 2019 +0300
+++ b/src/xitk/lirc.c	Wed Jul 24 17:26:38 2019 +0200
@@ -116,9 +116,9 @@
 	}
       }
       
-      if(panel_is_visible()) {
+      if(panel_is_visible(gGui->panel)) {
 	XLockDisplay(gGui->display);
-        panel_paint();
+        panel_paint(gGui->panel);
 	XUnlockDisplay(gGui->display);
       }
       

--------------DB77236A775E1E620077DA86
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--------------DB77236A775E1E620077DA86
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
xine-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xine-devel

--------------DB77236A775E1E620077DA86--